linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: net tree build warning
Date: Tue, 09 Jun 2009 13:25:27 +0200	[thread overview]
Message-ID: <4A2E46A7.6020302@grandegger.com> (raw)
In-Reply-To: <20090609203639.96e503fe.sfr@canb.auug.org.au>

Hello,

Stephen Rothwell wrote:
> Hi Dave,
> 
> Today's linux-next build (powerpc allyesconfig) produced these warnings:
> 
> drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_probe':
> drivers/net/can/sja1000/sja1000_of_platform.c:111: warning: format '%#x' expects type 'unsigned int', but argument 4 has type 'resource_size_t'
> drivers/net/can/sja1000/sja1000_of_platform.c:111: warning: format '%#x' expects type 'unsigned int', but argument 5 has type 'resource_size_t'
> drivers/net/can/sja1000/sja1000_of_platform.c:118: warning: format '%#x' expects type 'unsigned int', but argument 4 has type 'resource_size_t'
> drivers/net/can/sja1000/sja1000_of_platform.c:118: warning: format '%#x' expects type 'unsigned int', but argument 5 has type 'resource_size_t'
> 
> Introduced by commit d1a277c584d0862dbf51991baea947ea5f2ce6bf ("can:
> sja1000: generic OF platform bus driver").

The patch below should fix the build problems (which I cannot
reproduce on my test systems).

Thanks,

Wolfgang.

-----------------------------------------------------------------------
[PATCH] can: sja1000_of_platform: fix build problems with printk format

Variables of type size_t should be printed with the format "%zx".

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
---
 drivers/net/can/sja1000/sja1000_of_platform.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: net-next-2.6/drivers/net/can/sja1000/sja1000_of_platform.c
===================================================================
--- net-next-2.6.orig/drivers/net/can/sja1000/sja1000_of_platform.c	2009-06-09 12:45:38.000000000 +0200
+++ net-next-2.6/drivers/net/can/sja1000/sja1000_of_platform.c	2009-06-09 13:06:56.495718952 +0200
@@ -108,14 +108,14 @@
 	res_size = resource_size(&res);
 
 	if (!request_mem_region(res.start, res_size, DRV_NAME)) {
-		dev_err(&ofdev->dev, "couldn't request %#x..%#x\n",
+		dev_err(&ofdev->dev, "couldn't request %#zx..%#zx\n",
 			res.start, res.end);
 		return -EBUSY;
 	}
 
 	base = ioremap_nocache(res.start, res_size);
 	if (!base) {
-		dev_err(&ofdev->dev, "couldn't ioremap %#x..%#x\n",
+		dev_err(&ofdev->dev, "couldn't ioremap %#zx..%#zx\n",
 			res.start, res.end);
 		err = -ENOMEM;
 		goto exit_release_mem;

  reply	other threads:[~2009-06-09 11:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09 10:36 linux-next: net tree build warning Stephen Rothwell
2009-06-09 11:25 ` Wolfgang Grandegger [this message]
2009-06-09 11:26   ` David Miller
2009-06-09 13:14     ` Wolfgang Grandegger
2009-06-10  0:38       ` David Miller
2009-06-10  7:38         ` Wolfgang Grandegger
2009-06-10  8:12           ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2009-11-30  5:40 Stephen Rothwell
2009-11-30  9:49 ` Andrei Pelinescu-Onciul
2009-11-12  2:24 Stephen Rothwell
2009-11-12  2:53 ` David Miller
2009-11-12  2:55   ` Eric Dumazet
2009-11-12  3:10   ` Stephen Rothwell
2009-11-05  2:30 Stephen Rothwell
     [not found] <20090904144232.1f6ccf45.sfr@canb.auug.org.au>
2009-09-07  9:04 ` David Miller
2009-09-07  9:37   ` Stephen Rothwell
2009-09-04  4:28 Stephen Rothwell
2009-09-04  4:35 ` David Miller
2009-05-22  5:16 Stephen Rothwell
2009-05-22  6:30 ` David Miller
2009-05-22  8:20   ` Stephen Rothwell
2009-05-22 10:31     ` Neil Horman
2009-03-12  5:58 Stephen Rothwell
2009-03-12  6:24 ` David Miller
2009-03-12  6:42   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2E46A7.6020302@grandegger.com \
    --to=wg@grandegger.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).