From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Michael Chan <mchan@broadcom.com>,
linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: [PATCH -next] bnx2i/cnic: more kconfig dependencies
Date: Tue, 16 Jun 2009 10:25:45 -0700 [thread overview]
Message-ID: <4A37D599.5080701@oracle.com> (raw)
In-Reply-To: <20090616165923.8ca4ddcb.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle.com>
BNX2I selects CNIC, CNIC selects UIO.
It looks like BNX2I also needs to select UIO.
BTW, CNIC is under NETDEV_1000, which is not enabled.
I don't see any need to enable (select) it in this case,
but I could be wrong(?). Should BNX2I also select NETDEV_1000?
cnic.c:(.text+0x17990b): undefined reference to `uio_event_notify'
cnic.c:(.text+0x17a197): undefined reference to `uio_unregister_device'
cnic.c:(.text+0x17c618): undefined reference to `__uio_register_device'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/scsi/bnx2i/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20090616.orig/drivers/scsi/bnx2i/Kconfig
+++ linux-next-20090616/drivers/scsi/bnx2i/Kconfig
@@ -2,6 +2,7 @@ config SCSI_BNX2_ISCSI
tristate "Broadcom NetXtreme II iSCSI support"
select SCSI_ISCSI_ATTRS
select CNIC
+ select UIO
depends on PCI
---help---
This driver supports iSCSI offload for the Broadcom NetXtreme II
--
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
next prev parent reply other threads:[~2009-06-16 17:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 6:59 linux-next: Tree for June 16 Stephen Rothwell
2009-06-16 16:46 ` linux-next: Tree for June 16 (osd) Randy Dunlap
2009-06-17 12:45 ` Boaz Harrosh
2009-06-17 13:12 ` Stephen Rothwell
2009-06-17 13:36 ` [PATCH][SQUASHME] osdblk is dependent on SCSI_OSD_ULD Boaz Harrosh
2009-06-17 13:49 ` Stephen Rothwell
2009-06-17 16:20 ` Randy Dunlap
2009-06-16 17:25 ` Randy Dunlap [this message]
2009-06-16 17:57 ` [PATCH -next] bnx2i/cnic: more kconfig dependencies Michael Chan
2009-06-16 17:44 ` [PATCH -next] eeepc: fix selects (third time) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A37D599.5080701@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).