linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>, Jeff Garzik <jeff@garzik.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	scsi <linux-scsi@vger.kernel.org>,
	open-osd mailing-list <osd-dev@open-osd.org>
Subject: [PATCH][SQUASHME] osdblk is dependent on SCSI_OSD_ULD
Date: Wed, 17 Jun 2009 16:36:28 +0300	[thread overview]
Message-ID: <4A38F15C.5050204@panasas.com> (raw)
In-Reply-To: <20090617231250.4aefe5e8.sfr@canb.auug.org.au>

I will be squashing the below patch into the osdblk patch and will
rebase the "linux-next" branch. (No one is dependent on this branch
so there is no reason not too)

---
Stephen Rothwell wrote:
When
CONFIG_BLK_DEV_OSD=y
CONFIG_SCSI_OSD_INITIATOR=y
\# CONFIG_SCSI_OSD_ULD is not set

build fails with:
drivers/built-in.o: In function `class_osdblk_remove':
osdblk.c:(.text+0x55376): undefined reference to `osduld_put_device'
drivers/built-in.o: In function `class_osdblk_add':
osdblk.c:(.text+0x5564d): undefined reference to `osduld_path_lookup'
osdblk.c:(.text+0x5584d): undefined reference to `osduld_put_device'

Fix by setting the proper dependency for this driver

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
 drivers/block/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index 2f55a4b..1d886e0 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -300,7 +300,7 @@ config BLK_DEV_NBD
 
 config BLK_DEV_OSD
 	tristate "OSD object-as-blkdev support"
-	depends on SCSI_OSD_INITIATOR
+	depends on SCSI_OSD_ULD
 	---help---
 	  Saying Y or M here will allow the exporting of a single SCSI
 	  OSD (object-based storage) object as a Linux block device.
-- 
1.6.2.1

  reply	other threads:[~2009-06-17 13:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16  6:59 linux-next: Tree for June 16 Stephen Rothwell
2009-06-16 16:46 ` linux-next: Tree for June 16 (osd) Randy Dunlap
2009-06-17 12:45   ` Boaz Harrosh
2009-06-17 13:12     ` Stephen Rothwell
2009-06-17 13:36       ` Boaz Harrosh [this message]
2009-06-17 13:49         ` [PATCH][SQUASHME] osdblk is dependent on SCSI_OSD_ULD Stephen Rothwell
2009-06-17 16:20         ` Randy Dunlap
2009-06-16 17:25 ` [PATCH -next] bnx2i/cnic: more kconfig dependencies Randy Dunlap
2009-06-16 17:57   ` Michael Chan
2009-06-16 17:44 ` [PATCH -next] eeepc: fix selects (third time) Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A38F15C.5050204@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=osd-dev@open-osd.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).