From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: linux-next: Tree for June 17 (pci/slot) Date: Wed, 17 Jun 2009 10:43:36 -0700 Message-ID: <4A392B48.7060206@oracle.com> References: <20090617155354.075c60ae.sfr@canb.auug.org.au> <4A39194B.2060200@oracle.com> <20090617163604.GT19977@parisc-linux.org> <20090617102901.6e39aac2@jbarnes-g45> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090617102901.6e39aac2@jbarnes-g45> Sender: linux-pci-owner@vger.kernel.org To: Jesse Barnes Cc: Matthew Wilcox , Stephen Rothwell , linux-next@vger.kernel.org, LKML , Alex Chiang , "linux-pci@vger.kernel.org" List-Id: linux-next.vger.kernel.org Jesse Barnes wrote: > On Wed, 17 Jun 2009 10:36:04 -0600 > Matthew Wilcox wrote: > >> On Wed, Jun 17, 2009 at 09:26:51AM -0700, Randy Dunlap wrote: >>> Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20090616: >>> >>> When CONFIG_SYSFS=n: >>> >>> drivers/pci/slot.c:327: error: 'module_kset' undeclared (first use >>> in this function) >> Is there any point to pci_slot existing without CONFIG_SYSFS? >> I don't see how you can interact with it in any meaningful way. >> Perhaps CONFIG_PCI_SLOT should depend on CONFIG_SYSFS? > > I've got a code fix queued up, but maybe a Kconfig dependency is the > way to go... What is the code fix like? The Kconfig fix makes sense to me. -- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/