From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Anil Veerabhadrappa <anilgv@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
scsi <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: [PATCH -next] bnx2i/cnic: kconfig interactions
Date: Thu, 18 Jun 2009 09:55:17 -0700 [thread overview]
Message-ID: <4A3A7175.8080006@oracle.com> (raw)
In-Reply-To: <20090618145949.d933719a.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle.com>
NETDEVICES + NETDEV_1000 need to be enabled so that kconfig will check
those branches for selects and enforce "select UIO" under CNIC.
Otherwise the build fails with:
ERROR: "uio_unregister_device" [drivers/net/cnic.ko] undefined!
ERROR: "uio_event_notify" [drivers/net/cnic.ko] undefined!
ERROR: "__uio_register_device" [drivers/net/cnic.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
Cc: Michael Chan <mchan@broadcom.com>
---
drivers/scsi/bnx2i/Kconfig | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20090618.orig/drivers/scsi/bnx2i/Kconfig
+++ linux-next-20090618/drivers/scsi/bnx2i/Kconfig
@@ -1,6 +1,8 @@
config SCSI_BNX2_ISCSI
tristate "Broadcom NetXtreme II iSCSI support"
select SCSI_ISCSI_ATTRS
+ select NETDEVICES
+ select NETDEV_1000
select CNIC
depends on PCI
---help---
--
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
next prev parent reply other threads:[~2009-06-18 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 4:59 linux-next: Tree for June 18 Stephen Rothwell
2009-06-18 5:47 ` Len Brown
2009-06-18 6:47 ` Stephen Rothwell
2009-06-18 12:30 ` [s390x] Next June 18: boot failure Sachin Sant
2009-06-18 13:44 ` Martin Schwidefsky
2009-06-19 4:05 ` Sachin Sant
2009-06-22 7:27 ` Heiko Carstens
2009-06-22 9:05 ` Sachin Sant
2009-06-18 16:55 ` Randy Dunlap [this message]
2009-06-18 18:39 ` [PATCH -next] bnx2i/cnic: kconfig interactions Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3A7175.8080006@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anilgv@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).