linux-next: ubi tree build warnings

linux-next: ubi tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Hi Artem,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

drivers/mtd/ubi/io.c: In function 'nor_erase_prepare':
drivers/mtd/ubi/io.c:484: warning: passing argument 5 of 'ubi->mtd->write' from incompatible pointer type
drivers/mtd/ubi/io.c:484: note: expected 'const u_char *' but argument is of type 'uint32_t *'
drivers/mtd/ubi/io.c:486: warning: format '%zd' expects type 'signed size_t', but argument 5 has type 'int'
drivers/mtd/ubi/io.c:486: warning: too many arguments for format
drivers/mtd/ubi/io.c:493: warning: passing argument 5 of 'ubi->mtd->write' from incompatible pointer type
drivers/mtd/ubi/io.c:493: note: expected 'const u_char *' but argument is of type 'uint32_t *'

Introduced by commit ebf53f421308c2f59c9bcbad4c5c297a0d00199a ("UBI: fix
NOR flash recovery").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: ubi tree build warnings

[Artem Bityutskiy]

ext Stephen Rothwell wrote:
> Hi Artem,
> 
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> 
> drivers/mtd/ubi/io.c: In function 'nor_erase_prepare':
> drivers/mtd/ubi/io.c:484: warning: passing argument 5 of 'ubi->mtd->write' from incompatible pointer type
> drivers/mtd/ubi/io.c:484: note: expected 'const u_char *' but argument is of type 'uint32_t *'
> drivers/mtd/ubi/io.c:486: warning: format '%zd' expects type 'signed size_t', but argument 5 has type 'int'
> drivers/mtd/ubi/io.c:486: warning: too many arguments for format
> drivers/mtd/ubi/io.c:493: warning: passing argument 5 of 'ubi->mtd->write' from incompatible pointer type
> drivers/mtd/ubi/io.c:493: note: expected 'const u_char *' but argument is of type 'uint32_t *'
> 
> Introduced by commit ebf53f421308c2f59c9bcbad4c5c297a0d00199a ("UBI: fix
> NOR flash recovery").

Will fix ASAP, thank you! I'm always wondering how you manage
to reproduce warnings I do not see.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

Re: linux-next: ubi tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi Artem,

On Wed, 08 Jul 2009 07:45:06 +0300 Artem Bityutskiy <Artem.Bityutskiy@nokia.com> wrote:
>
> Will fix ASAP, thank you! I'm always wondering how you manage
> to reproduce warnings I do not see.

Probably a different config or compiler (I am using gcc 4.4.0).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: ubi tree build warnings

[Artem Bityutskiy]

Stephen Rothwell wrote:
> Hi Artem,
> 
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> 
> drivers/mtd/ubi/io.c: In function 'nor_erase_prepare':
> drivers/mtd/ubi/io.c:484: warning: passing argument 5 of 'ubi->mtd->write' from incompatible pointer type
> drivers/mtd/ubi/io.c:484: note: expected 'const u_char *' but argument is of type 'uint32_t *'
> drivers/mtd/ubi/io.c:486: warning: format '%zd' expects type 'signed size_t', but argument 5 has type 'int'
> drivers/mtd/ubi/io.c:486: warning: too many arguments for format
> drivers/mtd/ubi/io.c:493: warning: passing argument 5 of 'ubi->mtd->write' from incompatible pointer type
> drivers/mtd/ubi/io.c:493: note: expected 'const u_char *' but argument is of type 'uint32_t *'
> 
> Introduced by commit ebf53f421308c2f59c9bcbad4c5c297a0d00199a ("UBI: fix
> NOR flash recovery").

Fixed the warnings. In fact I do see them, but did not notice
them before. Thanks a lot for catching this and keeping our
kernel clean.

Pushed the fix:
http://git.infradead.org/ubi-2.6.git?a=commit;h=83c2099f5e1f0a4621ed4f20fc539069c636a24b

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)