From: Randy Dunlap <rdunlap@xenotime.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>
Cc: Greg KH <gregkh@suse.de>, Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH -next] staging/sep: fix build error & warning & kconfig
Date: Mon, 17 Aug 2009 13:35:30 -0700 [thread overview]
Message-ID: <4A89BF12.6020908@xenotime.net> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix sep_driver build when CONFIG_PCI=n:
drivers/staging/sep/sep_driver.c:2548: error: implicit declaration of function 'pci_dev_get'
and printk format warning:
drivers/staging/sep/sep_driver.c:290:
warning: format '%d' expects type 'int', but argument 2 has type 'long unsigned
int'
Also, the default kconfig value should not be 'y'.
And something should be done about this warning (but I didn't fix it):
drivers/staging/sep/sep_driver.c:1780: warning: 'error' may be used uninitialized in this function
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/staging/sep/Kconfig | 3 +--
drivers/staging/sep/sep_driver.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--- linux-next-20090817.orig/drivers/staging/sep/Kconfig
+++ linux-next-20090817/drivers/staging/sep/Kconfig
@@ -1,8 +1,7 @@
config DX_SEP
tristate "Discretix SEP driver"
# depends on MRST
- depends on RAR_REGISTER
- default y
+ depends on RAR_REGISTER && PCI
help
Discretix SEP driver
--- linux-next-20090817.orig/drivers/staging/sep/sep_driver.c
+++ linux-next-20090817/drivers/staging/sep/sep_driver.c
@@ -287,7 +287,7 @@ static int sep_map_and_alloc_shared_area
sep->shared_area = sep->shared_addr;
/* set the physical address of the shared area */
sep->shared_area_bus = sep->shared_bus;
- edbg("sep: shared_area %d bytes @%p (bus %08llx)\n",
+ edbg("sep: shared_area %lu bytes @%p (bus %08llx)\n",
size, sep->shared_addr, (unsigned long long)sep->shared_bus);
return 0;
}
--
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
next reply other threads:[~2009-08-17 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 20:35 Randy Dunlap [this message]
2009-08-17 20:42 ` [PATCH -next] staging/sep: fix build error & warning & kconfig Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89BF12.6020908@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).