From: Eric Miao <eric.y.miao@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Eric Miao <eric.y.miao@gmail.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"Aric D. Blumer" <aric@sdgsystems.com>,
Mike Rapoport <mike@compulab.co.il>,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: linux-next: usb/pxa trees build failure
Date: Tue, 18 Aug 2009 22:05:25 +0800 [thread overview]
Message-ID: <4A8AB525.7050404@gmail.com> (raw)
In-Reply-To: <20090818114242.GA28534@kroah.com>
Greg KH wrote:
> On Tue, Aug 18, 2009 at 01:58:52PM +1000, Stephen Rothwell wrote:
>> Hi Eric, Greg,
>>
>> The next-20090817 (and a few before) build (arm trizeps4_defconfig)
>> failed like this:
>>
>> drivers/usb/host/ohci-pxa27x.c:507: error: 'pdev' undeclared (first use in this function)
>>
>> Caused by the interaction of commit
>> 6458baec17e19d38b9d4eb1f96c213f91609c0e3 ("USB: ohci-pxa27x: Reconfigure
>> power settings on resume") from the usb tree with commit
>> b8fb7d4317bcea1b48c9560d23dff81121870ece ("[ARM] pxa: update
>> ohci-pxa27x.c to use 'struct dev_pm_ops'"). from the pxa tree.
>>
>> Greg/Aric, maybe that usb tree patch needs to go through the pxa tree?
>> (and maybe "USB: ohci-pxa27x: Allow NOCP and OCPM to be cleared" as well?)
>>
>> [this also broke the following configs: magician_defconfig,
>> em_x270_defconfig and cm_x2xx_defconfig.]
>
> Ick, not good. Aric, should I drop this patch from my tree?
>
I think so, might be better to go through the pxa tree so that I can give
another review. (the fiber across the pacific seems to be broken again, so
I have to look into this tomorrow, still fetching -next, sigh).
next prev parent reply other threads:[~2009-08-18 14:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090818135852.0b3b648d.sfr@canb.auug.org.au>
2009-08-18 11:42 ` linux-next: usb/pxa trees build failure Greg KH
2009-08-18 14:05 ` Eric Miao [this message]
2009-08-18 14:58 ` Greg KH
2009-08-19 1:15 ` Aric D. Blumer
2009-08-19 3:07 ` Eric Miao
2009-08-19 2:35 ` Eric Miao
2009-08-19 17:22 ` Greg KH
2009-08-19 18:24 ` Aric D. Blumer
2009-08-19 23:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8AB525.7050404@gmail.com \
--to=eric.y.miao@gmail.com \
--cc=aric@sdgsystems.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=rmk@arm.linux.org.uk \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).