From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Miao Subject: Re: linux-next: usb/pxa trees build failure Date: Tue, 18 Aug 2009 22:05:25 +0800 Message-ID: <4A8AB525.7050404@gmail.com> References: <20090818135852.0b3b648d.sfr@canb.auug.org.au> <20090818114242.GA28534@kroah.com> Reply-To: eric.y.miao@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from rv-out-0506.google.com ([209.85.198.225]:31453 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754148AbZHROFj (ORCPT ); Tue, 18 Aug 2009 10:05:39 -0400 In-Reply-To: <20090818114242.GA28534@kroah.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Greg KH Cc: Stephen Rothwell , Eric Miao , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, "Aric D. Blumer" , Mike Rapoport , Russell King Greg KH wrote: > On Tue, Aug 18, 2009 at 01:58:52PM +1000, Stephen Rothwell wrote: >> Hi Eric, Greg, >> >> The next-20090817 (and a few before) build (arm trizeps4_defconfig) >> failed like this: >> >> drivers/usb/host/ohci-pxa27x.c:507: error: 'pdev' undeclared (first use in this function) >> >> Caused by the interaction of commit >> 6458baec17e19d38b9d4eb1f96c213f91609c0e3 ("USB: ohci-pxa27x: Reconfigure >> power settings on resume") from the usb tree with commit >> b8fb7d4317bcea1b48c9560d23dff81121870ece ("[ARM] pxa: update >> ohci-pxa27x.c to use 'struct dev_pm_ops'"). from the pxa tree. >> >> Greg/Aric, maybe that usb tree patch needs to go through the pxa tree? >> (and maybe "USB: ohci-pxa27x: Allow NOCP and OCPM to be cleared" as well?) >> >> [this also broke the following configs: magician_defconfig, >> em_x270_defconfig and cm_x2xx_defconfig.] > > Ick, not good. Aric, should I drop this patch from my tree? > I think so, might be better to go through the pxa tree so that I can give another review. (the fiber across the pacific seems to be broken again, so I have to look into this tomorrow, still fetching -next, sigh).