From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Ungerer Subject: Re: linux-next: m86k/m68knommu tree build failure Date: Fri, 18 Sep 2009 16:09:37 +1000 Message-ID: <4AB32421.5010207@snapgear.com> References: <20090910151137.fb71c103.sfr@canb.auug.org.au> <4AA890B5.8000207@snapgear.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rex.securecomputing.com ([203.24.151.4]:50597 "EHLO cyberguard.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751317AbZIRGKH (ORCPT ); Fri, 18 Sep 2009 02:10:07 -0400 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Andreas Schwab Cc: Stephen Rothwell , Geert Uytterhoeven , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Hi Andreas, Andreas Schwab wrote: > Greg Ungerer writes: > >> Hi Stephen, >> >> Stephen Rothwell wrote: >>> Today's linux-next build (m68k defconfig) failed like this: >>> >>> kernel/built-in.o: In function `ptrace_resume': >>> ptrace.c:(.text+0xc5d6): undefined reference to `user_disable_single_step' >>> ptrace.c:(.text+0xc5fe): undefined reference to `user_enable_single_step' >>> ptrace.c:(.text+0xc620): undefined reference to `user_disable_single_step' >>> >>> Caused by commit 5db612ef70d24be12f6dbf5d06b23bcd6bc2fc05 ("m68knommu: >>> define arch_has_single_step() and friends"). This commit added >>> definitions of these functions for m68knommu, but added declarations (and >>> arch_has_single_step()) in a common header file. >> Ah, yes, thanks. I'll fix that. I don't regularly build for m68k, >> so I missed that in my test builds. > > An m68k implementation is here > . Thanks for the pointer. I have something similar I have been working on for m68knommu. I'll follow up here with the new patches soon. Regards Greg ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com