[-next PATCH] Add param ops struct for hvc_iucv driver.

[-next PATCH] Add param ops struct for hvc_iucv driver.

[Sachin Sant]

Today's next 20091117 build failed on s390 with

drivers/char/hvc_iucv.c:1331: error: 'param_ops_vmidfilter' undeclared here (not in a function)
make[2]: *** [drivers/char/hvc_iucv.o] Error 1

Most probably caused by commit 684a6d340b8a5767db4670031b0f39455346018a
(param:param_ops) which introduced a param_ops structure.

The following compile tested patch adds a param_ops structure for hvc_iucv.

Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
---

diff -Naurp a/drivers/char/hvc_iucv.c b/drivers/char/hvc_iucv.c
--- a/drivers/char/hvc_iucv.c	2009-11-13 06:16:07.000000000 +0530
+++ b/drivers/char/hvc_iucv.c	2009-11-17 18:34:30.000000000 +0530
@@ -1146,7 +1146,7 @@ out_err:
  * Note: If it is called early in the boot process, @val is stored and
  *	 parsed later in hvc_iucv_init().
  */
-static int param_set_vmidfilter(const char *val, struct kernel_param *kp)
+static int param_set_vmidfilter(const char *val, const struct kernel_param *kp)
 {
 	int rc;
 
@@ -1173,7 +1173,7 @@ static int param_set_vmidfilter(const ch
  * The function stores the filter as a comma-separated list of z/VM user IDs
  * in @buffer. Typically, sysfs routines call this function for attr show.
  */
-static int param_get_vmidfilter(char *buffer, struct kernel_param *kp)
+static int param_get_vmidfilter(char *buffer, const struct kernel_param *kp)
 {
 	int rc;
 	size_t index, len;
@@ -1200,6 +1200,11 @@ static int param_get_vmidfilter(char *bu
 
 #define param_check_vmidfilter(name, p) __param_check(name, p, void)
 
+static struct kernel_param_ops param_ops_vmidfilter = {
+        .set = param_set_vmidfilter,
+        .get = param_get_vmidfilter,
+};
+
 /**
  * hvc_iucv_init() - z/VM IUCV HVC device driver initialization
  */

Re: [-next PATCH] Add param ops struct for hvc_iucv driver.

[Heiko Carstens]

On Tue, Nov 17, 2009 at 06:51:03PM +0530, Sachin Sant wrote:
> Today's next 20091117 build failed on s390 with
> 
> drivers/char/hvc_iucv.c:1331: error: 'param_ops_vmidfilter' undeclared here (not in a function)
> make[2]: *** [drivers/char/hvc_iucv.o] Error 1
> 
> Most probably caused by commit 684a6d340b8a5767db4670031b0f39455346018a
> (param:param_ops) which introduced a param_ops structure.
> 
> The following compile tested patch adds a param_ops structure for hvc_iucv.
> 
> Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
> ---

Yep, thanks. I just did the same.

Rusty, could you pick this one up?

Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>

Re: [-next PATCH] Add param ops struct for hvc_iucv driver.

[Rusty Russell]

On Tue, 17 Nov 2009 11:54:48 pm Heiko Carstens wrote:
> On Tue, Nov 17, 2009 at 06:51:03PM +0530, Sachin Sant wrote:
> > The following compile tested patch adds a param_ops structure for hvc_iucv.
> > 
...
> Rusty, could you pick this one up?
> 
> Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>

Thanks, applied, fixed spaces which should have been tabs.

Cheers,
Rusty.

Re: [-next PATCH] Add param ops struct for hvc_iucv driver.

[Sachin Sant]

Rusty Russell wrote:
> Thanks, applied, fixed spaces which should have been tabs.
Sorry about that. Would be more careful.

Thanks
-Sachin

-- 

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------