linux-next: microblaze tree build failure

linux-next: microblaze tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

Hi Michal,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/built-in.o: In function `.ofdt_write':
reconfig.c:(.text+0xca08): undefined reference to `.of_attach_node'
arch/powerpc/platforms/built-in.o: In function `.do_device_node':
vio.c:(.text+0x1be2c): undefined reference to `.of_attach_node'

Caused by commit 5d0c1c076548e1f8d590a2f70f281b4eb7b3aeb2 ("Merge
of_attach_node") which I have reverted for today.  That patch is missing
an update to drivers/of/Makefile at least ... and probably some other
stuff as well.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: microblaze tree build failure

[Nathan Fontenot]

Yes, this should be rejected.  I have submitted an updated patch to
linuxppc-dev and devicetree-discuss.

I'm not sure how this patch git picked up, I didn't think it did.
Looking at the coimmit it appears that only patch 1/4 of the patchset
was picked up.

-Nathan Fontenot

Stephen Rothwell wrote:
> Hi Michal,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> arch/powerpc/platforms/built-in.o: In function `.ofdt_write':
> reconfig.c:(.text+0xca08): undefined reference to `.of_attach_node'
> arch/powerpc/platforms/built-in.o: In function `.do_device_node':
> vio.c:(.text+0x1be2c): undefined reference to `.of_attach_node'
> 
> Caused by commit 5d0c1c076548e1f8d590a2f70f281b4eb7b3aeb2 ("Merge
> of_attach_node") which I have reverted for today.  That patch is missing
> an update to drivers/of/Makefile at least ... and probably some other
> stuff as well.
> 

Re: linux-next: microblaze tree build failure

[Grant Likely]

On Thu, Nov 19, 2009 at 3:56 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Michal,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> arch/powerpc/platforms/built-in.o: In function `.ofdt_write':
> reconfig.c:(.text+0xca08): undefined reference to `.of_attach_node'
> arch/powerpc/platforms/built-in.o: In function `.do_device_node':
> vio.c:(.text+0x1be2c): undefined reference to `.of_attach_node'
>
> Caused by commit 5d0c1c076548e1f8d590a2f70f281b4eb7b3aeb2 ("Merge
> of_attach_node") which I have reverted for today.  That patch is missing
> an update to drivers/of/Makefile at least ... and probably some other
> stuff as well.

... and the OF changes shouldn't be going through the microblaze tree.
 This looks like it was an accident.  Michal?

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.