From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Gregory Haskins <gregory.haskins@gmail.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Mark McLoughlin <markmc@redhat.com>, Greg KH <gregkh@suse.de>,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: linux-next: alacrity tree build failure
Date: Tue, 24 Nov 2009 16:41:05 -0800 [thread overview]
Message-ID: <4B0C7D21.7010008@goop.org> (raw)
In-Reply-To: <20091124185843.d2cab90c.sfr@canb.auug.org.au>
On 11/23/09 23:58, Stephen Rothwell wrote:
> Today's linux-next build (x86_6 _allmodconfig) failed like this:
>
> drivers/vbus/built-in.o:(.data+0x0): multiple definition of `dev_attr_modalias'
> drivers/xen/built-in.o:(.data+0x46d0): first defined here
>
> Caused by commit 59aa8f441d27c8470764a513dafa46a77f33e953 ("vbus: add
> autoprobe capability to guest"). The DEVICE_ATTR(modalias ...) should
> probably be static. I should probably be static in
> drivers/xen/xenbus/xenbus_probe.c as well.
>
All those DEVICE_ATTR()s should be static in that case. Indeed, I guess
they should be almost universally? Should DEVICE_ATTR() include the
static? (Hm, almost every instance in the kernel already has static; it
should probably have been part of the definition from the start, but
changing it now would cause a lot of churn.)
J
next prev parent reply other threads:[~2009-11-25 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 7:58 linux-next: alacrity tree build failure Stephen Rothwell
2009-11-25 0:41 ` Jeremy Fitzhardinge [this message]
2009-11-25 0:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0C7D21.7010008@goop.org \
--to=jeremy@goop.org \
--cc=gregkh@suse.de \
--cc=gregory.haskins@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).