From: Tejun Heo <tj@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Andy Walls <awalls@radix.net>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: linux-next: workqueues tree build failure
Date: Fri, 27 Nov 2009 17:42:27 +0900 [thread overview]
Message-ID: <4B0F90F3.2010204@kernel.org> (raw)
In-Reply-To: <s5h3a40pdm7.wl%tiwai@suse.de>
Hello,
11/27/2009 05:37 PM, Takashi Iwai wrote:
>> Sounds like it should be using bottom half tasklet not workqueue.
>> Tasklet is exactly designed to handle situations like this. Is there
>> any reason tasklet can't be used?
>
> Right now the h/w accessing code is using mutex. I'm not sure whether
> the deeper part might sleep, though...
Ah... I see. Using mutex from a handler where response time is
critical is strange tho. Anyways, I don't really think singlethread
will satisfy the timing requirement under loaded conditions. IMHO,
update locking and using tasklets would be the best.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-11-27 8:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 8:00 linux-next: workqueues tree build failure Stephen Rothwell
2009-11-26 8:04 ` Tejun Heo
2009-11-26 8:16 ` Peter Ujfalusi
2009-11-26 9:12 ` Tejun Heo
2009-11-26 9:24 ` Takashi Iwai
2009-11-26 9:31 ` Peter Ujfalusi
2009-11-26 10:18 ` Mark Brown
2009-11-26 11:44 ` Peter Ujfalusi
2009-11-26 12:49 ` Andy Walls
2009-11-26 13:23 ` Peter Ujfalusi
2009-11-26 12:40 ` Andy Walls
2009-11-26 12:56 ` Mark Brown
2009-11-27 2:02 ` Tejun Heo
2009-11-27 8:37 ` Takashi Iwai
2009-11-27 8:42 ` Tejun Heo [this message]
2009-11-27 10:09 ` Peter Ujfalusi
2009-11-27 11:38 ` Mark Brown
2009-11-27 13:50 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0F90F3.2010204@kernel.org \
--to=tj@kernel.org \
--cc=awalls@radix.net \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=sfr@canb.auug.org.au \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).