* PATCH] staging: fix a silly typo
@ 2009-11-30 17:09 Alan Cox
2009-11-30 17:10 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2009-11-30 17:09 UTC (permalink / raw)
To: linux-next, greg
Can this either get applied or Rusty's tree dropped. This has been broken
for ages now, and at the point something like "sizeof" spelled wrongly
gets into a tree and doesn't get caught by the submitter or fixed for
weeks when pointed out something is badly wrong
--
staging: fix a silly typo
From: Alan Cox <alan@linux.intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/staging/rtl8187se/r8180_core.c | 2 +-
drivers/staging/rtl8192su/r8192U_core.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index 5a6cd60..d74bf70 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -79,7 +79,7 @@ MODULE_AUTHOR("Andrea Merello <andreamrl@tiscali.it>");
MODULE_DESCRIPTION("Linux driver for Realtek RTL8180 / RTL8185 WiFi cards");
-module_param_string(ifname, ifname, sizef(ifname), S_IRUGO|S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO|S_IWUSR);
module_param(hwseqnum,int, S_IRUGO|S_IWUSR);
module_param(hwwep,int, S_IRUGO|S_IWUSR);
module_param(channels,int, S_IRUGO|S_IWUSR);
diff --git a/drivers/staging/rtl8192su/r8192U_core.c b/drivers/staging/rtl8192su/r8192U_core.c
index e24815f..0a052ea 100644
--- a/drivers/staging/rtl8192su/r8192U_core.c
+++ b/drivers/staging/rtl8192su/r8192U_core.c
@@ -142,7 +142,7 @@ static int channels = 0x3fff;
-module_param_string(ifname, ifname, sizef(ifname), S_IRUGO|S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO|S_IWUSR);
//module_param(hwseqnum,int, S_IRUGO|S_IWUSR);
module_param(hwwep,int, S_IRUGO|S_IWUSR);
module_param(channels,int, S_IRUGO|S_IWUSR);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: PATCH] staging: fix a silly typo
2009-11-30 17:09 PATCH] staging: fix a silly typo Alan Cox
@ 2009-11-30 17:10 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2009-11-30 17:10 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-next, greg
Alan Cox wrote:
> Can this either get applied or Rusty's tree dropped. This has been broken
> for ages now, and at the point something like "sizeof" spelled wrongly
> gets into a tree and doesn't get caught by the submitter or fixed for
> weeks when pointed out something is badly wrong
>
> --
> staging: fix a silly typo
>
> From: Alan Cox <alan@linux.intel.com>
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/staging/rtl8187se/r8180_core.c | 2 +-
> drivers/staging/rtl8192su/r8192U_core.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index 5a6cd60..d74bf70 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -79,7 +79,7 @@ MODULE_AUTHOR("Andrea Merello <andreamrl@tiscali.it>");
> MODULE_DESCRIPTION("Linux driver for Realtek RTL8180 / RTL8185 WiFi cards");
>
>
> -module_param_string(ifname, ifname, sizef(ifname), S_IRUGO|S_IWUSR);
> +module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO|S_IWUSR);
> module_param(hwseqnum,int, S_IRUGO|S_IWUSR);
> module_param(hwwep,int, S_IRUGO|S_IWUSR);
> module_param(channels,int, S_IRUGO|S_IWUSR);
> diff --git a/drivers/staging/rtl8192su/r8192U_core.c b/drivers/staging/rtl8192su/r8192U_core.c
> index e24815f..0a052ea 100644
> --- a/drivers/staging/rtl8192su/r8192U_core.c
> +++ b/drivers/staging/rtl8192su/r8192U_core.c
> @@ -142,7 +142,7 @@ static int channels = 0x3fff;
>
>
>
> -module_param_string(ifname, ifname, sizef(ifname), S_IRUGO|S_IWUSR);
> +module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO|S_IWUSR);
> //module_param(hwseqnum,int, S_IRUGO|S_IWUSR);
> module_param(hwwep,int, S_IRUGO|S_IWUSR);
> module_param(channels,int, S_IRUGO|S_IWUSR);
> --
There is also a strcpt() that should be strcpy().
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-30 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-30 17:09 PATCH] staging: fix a silly typo Alan Cox
2009-11-30 17:10 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).