linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	gregkh@suse.de, linux-next@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: IIO: add selection of IIO_SW_RING to LIS3L02DQ as needed
Date: Mon, 07 Dec 2009 09:07:53 -0800	[thread overview]
Message-ID: <4B1D3669.4020204@oracle.com> (raw)
In-Reply-To: <4B1D1CF5.6030502@cam.ac.uk>

Jonathan Cameron wrote:
> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.


> ---
> 
>  Thanks to Randy for the report. Sorry for the slow response.
>  I've been meaning to carefully check for any remaining cases like
>  this.
>  Here I've kept the selection of IIO_SW_RING separate from
>  IIO_TRIGGER as it will go away fairly shortly when the ring buffer
>  type becomes configurable on a per device basis, whereas the
>  IIO_TRIGGER select will remain. Whether to retain the option to
>  remove the support for ring buffers entirely is one for after that
>  support is in place.
> 
>  Touch wood I think this is the last one, but I'll try a selection of
>  unusual combinations now and post others as replies to this email.
> 
>  drivers/staging/iio/accel/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/Kconfig b/drivers/staging/iio/accel/Kconfig
> index 4044663..3d3c333 100644
> --- a/drivers/staging/iio/accel/Kconfig
> +++ b/drivers/staging/iio/accel/Kconfig
> @@ -14,6 +14,7 @@ config LIS3L02DQ
>  	tristate "ST Microelectronics LIS3L02DQ Accelerometer Driver"
>  	depends on SPI
>  	select IIO_TRIGGER if IIO_RING_BUFFER
> +	select IIO_SW_RING if IIO_RING_BUFFER
>  	help
>  	  Say yes here to build SPI support for the ST microelectronics
>  	  accelerometer. The driver supplies direct access via sysfs files


-- 
~Randy

  reply	other threads:[~2009-12-07 17:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04  9:30 linux-next: Tree for December 4 Stephen Rothwell
2009-12-04  9:44 ` Michal Simek
2009-12-04 10:44   ` Stephen Rothwell
2009-12-06 18:00 ` [PATCH -next resend] staging: vt6x depends on WLAN Randy Dunlap
2009-12-06 18:03 ` [PATCH -next resend] g_multi kconfig: fix depends and help text Randy Dunlap
2009-12-06 18:04 ` [PATCH -next resend/fixed] media/miro: fix kconfig depends/select Randy Dunlap
2009-12-06 18:12 ` linux-next: Tree for December 4 (staging/iio) Randy Dunlap
2009-12-07 15:19   ` [PATCH] Staging: IIO: add selection of IIO_SW_RING to LIS3L02DQ as needed Jonathan Cameron
2009-12-07 17:07     ` Randy Dunlap [this message]
2009-12-06 22:27 ` linux-next: Tree for December 4 (comedi) Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B1D3669.4020204@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=gregkh@suse.de \
    --cc=jic23@cam.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).