From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sachin Sant Subject: Re: [Next] CPU Hotplug test failures on powerpc Date: Wed, 16 Dec 2009 11:08:10 +0530 Message-ID: <4B287242.5070002@in.ibm.com> References: <4B2224C7.1020908@in.ibm.com> <1260786122.4165.142.camel@twins> <4B261D7A.9040802@in.ibm.com> <1260793182.4165.223.camel@twins> <1260825420.2217.40.camel@pasglop> <4B275A6B.9030200@in.ibm.com> <1260873827.4165.362.camel@twins> <4B279370.5050800@in.ibm.com> <1260889402.4165.434.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from e23smtp08.au.ibm.com ([202.81.31.141]:42891 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606AbZLPFiT (ORCPT ); Wed, 16 Dec 2009 00:38:19 -0500 In-Reply-To: <1260889402.4165.434.camel@twins> Sender: linux-next-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Benjamin Herrenschmidt , Linux/PPC Development , linux-kernel , Ingo Molnar , linux-next@vger.kernel.org Peter Zijlstra wrote: > Could you try the below? > No luck. Still the same issue. The mask values don't change. Thanks -Sachin > --- > init/main.c | 7 +------ > 1 files changed, 1 insertions(+), 6 deletions(-) > > diff --git a/init/main.c b/init/main.c > index 4051d75..4be7de2 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -369,12 +369,6 @@ static void __init smp_init(void) > { > unsigned int cpu; > > - /* > - * Set up the current CPU as possible to migrate to. > - * The other ones will be done by cpu_up/cpu_down() > - */ > - set_cpu_active(smp_processor_id(), true); > - > /* FIXME: This should be done in userspace --RR */ > for_each_present_cpu(cpu) { > if (num_online_cpus() >= setup_max_cpus) > @@ -486,6 +480,7 @@ static void __init boot_cpu_init(void) > int cpu = smp_processor_id(); > /* Mark the boot cpu "present", "online" etc for SMP and UP case */ > set_cpu_online(cpu, true); > + set_cpu_active(cpu, true); > set_cpu_present(cpu, true); > set_cpu_possible(cpu, true); > } > > > -- --------------------------------- Sachin Sant IBM Linux Technology Center India Systems and Technology Labs Bangalore, India ---------------------------------