linux-next: kgdb tree build failure

linux-next: kgdb tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Hi Jason,

Today's linux-next build (i386 defconfig) failed like this:

drivers/built-in.o: In function `drm_fb_kdb_enter':
drm_fb_helper.c:(.text+0x6567a): undefined reference to `kgdb_active'
drivers/built-in.o: In function `drm_fb_helper_free':
(.text+0x65ec7): undefined reference to `dbg_kms_console_ops_unregister'
drivers/built-in.o: In function `drm_fb_helper_single_fb_probe':
(.text+0x6645d): undefined reference to `dbg_kms_console_ops_register'

Clearly, the kgdb patches need some more testing.  Please remove them
from linux-next until that is done.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: kgdb tree build failure

[Jason Wessel]

Stephen Rothwell wrote:
> Hi Jason,
>
> Today's linux-next build (i386 defconfig) failed like this:
>
> drivers/built-in.o: In function `drm_fb_kdb_enter':
> drm_fb_helper.c:(.text+0x6567a): undefined reference to `kgdb_active'
> drivers/built-in.o: In function `drm_fb_helper_free':
> (.text+0x65ec7): undefined reference to `dbg_kms_console_ops_unregister'
> drivers/built-in.o: In function `drm_fb_helper_single_fb_probe':
> (.text+0x6645d): undefined reference to `dbg_kms_console_ops_register'
>
> Clearly, the kgdb patches need some more testing.  Please remove them
> from linux-next until that is done.
>
>   

All the kdb patches were dropped from kgdb-next / linux-next.  All the
embedded type configs build and boot just fine.   The root of the
problem was that there was a gap in testing all the various combinations
where you can builds some things as a module or somethings as a built in.

The error you reported is already fixed, but the code base will not be
resubmitted until a new round of build and boot tests are completed.

Thanks,
Jason.

Re: linux-next: kgdb tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hi Jason,

On Wed, 23 Dec 2009 21:58:52 -0600 Jason Wessel <jason.wessel@windriver.com> wrote:
>
> All the kdb patches were dropped from kgdb-next / linux-next.  All the
> embedded type configs build and boot just fine.   The root of the
> problem was that there was a gap in testing all the various combinations
> where you can builds some things as a module or somethings as a built in.
> 
> The error you reported is already fixed, but the code base will not be
> resubmitted until a new round of build and boot tests are completed.

Thanks for that.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: kgdb tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi Jason,

Today's linux-next build (arm realview_defconfig) failed like this:

arch/arm/kernel/traps.c: In function 'die':
arch/arm/kernel/traps.c:260: error: implicit declaration of function 'kgdb_die_hook'

Caused by commit a5fdc3c5dddc4eca77e06bc727c2c2cce349a498 ("arm,kgdb: Add
hook to catch an oops with debugger").  CONFIG_KGDB is not set.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: kgdb tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

Hi Jason,

On Mon, 4 Jan 2010 16:42:09 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (arm realview_defconfig) failed like this:
                                ^^^^^^^^^
Most of the other arm builds failed the same way ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: kgdb tree build failure

[Jason Wessel]

Stephen Rothwell wrote:
> Hi Jason,
>
> On Mon, 4 Jan 2010 16:42:09 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>   
>> Today's linux-next build (arm realview_defconfig) failed like this:
>>     
>                                 ^^^^^^^^^
> Most of the other arm builds failed the same way ...
>
>   

That patch could have been dropped from the series, but I did repair the
problem.  I also added a 3 more config tests (sparc, arm and ppc) to my
pre-submission test list.

kgdb-next is updated and I can only hope the light is at the end of the
tunnel for the config testing. :-)

Thanks,
Jason.

Re: linux-next: kgdb tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Hi Jason,

On Mon, 04 Jan 2010 06:55:30 -0600 Jason Wessel <jason.wessel@windriver.com> wrote:
>
> That patch could have been dropped from the series, but I did repair the
> problem.  I also added a 3 more config tests (sparc, arm and ppc) to my
> pre-submission test list.
> 
> kgdb-next is updated and I can only hope the light is at the end of the
> tunnel for the config testing. :-)

OK, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: kgdb tree build failure

[Stephen Rothwell]

Hi Jason,

Today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: "kgdb_active" [drivers/video/console/fbcon.ko] undefined!
ERROR: "want_console" [drivers/serial/kgdboc.ko] undefined!
ERROR: "last_console" [drivers/serial/kgdboc.ko] undefined!
ERROR: "kgdb_active" [drivers/gpu/drm/drm_kms_helper.ko] undefined!

Caused by various commits from the kgdb tree.

I added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 24 Dec 2009 11:10:41 +1100
Subject: [PATCH] kgdb: export symbols used by modules

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/char/vt.c         |    2 ++
 kernel/debug/debug_core.c |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 50faa1f..ef106d8 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -190,7 +190,9 @@ static DECLARE_WORK(console_work, console_callback);
  */
 int fg_console;
 int last_console;
+EXPORT_SYMBOL_GPL(last_console);
 int want_console = -1;
+EXPORT_SYMBOL_GPL(want_console);
 
 /*
  * For each existing display, we have a pointer to console currently visible
diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
index 14d7c4e..c58924f 100644
--- a/kernel/debug/debug_core.c
+++ b/kernel/debug/debug_core.c
@@ -106,6 +106,7 @@ static struct kgdb_bkpt		kgdb_break[KGDB_MAX_BREAKPOINTS] = {
  * The CPU# of the active CPU, or -1 if none:
  */
 atomic_t			kgdb_active = ATOMIC_INIT(-1);
+EXPORT_SYMBOL_GPL(kgdb_active);
 
 /*
  * We use NR_CPUs not PERCPU, in case kgdb is used to debug early
-- 
1.6.5.4


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/