From: Sachin Sant <sachinp@in.ibm.com>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: linux-s390@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: next Jan 6: drivers/s390/char/defkeymap build break
Date: Thu, 07 Jan 2010 11:33:51 +0530 [thread overview]
Message-ID: <4B457947.2040004@in.ibm.com> (raw)
In-Reply-To: <4B44B6F8.9070209@windriver.com>
Jason Wessel wrote:
> Sachin Sant wrote:
>
>> Today's next fails to build on s390 with
>>
>> CC drivers/s390/char/defkeymap.o
>> drivers/s390/char/defkeymap.c:30: error: static declaration of 'shift_map' follows non-static declaration
>> include/linux/keyboard.h:31: error: previous declaration of 'shift_map' was here
>> drivers/s390/char/defkeymap.c:49: error: static declaration of 'ctrl_map' follows non-static declaration
>> include/linux/keyboard.h:32: error: previous declaration of 'ctrl_map' was here
>> make[2]: *** [drivers/s390/char/defkeymap.o] Error 1
>> make[1]: *** [drivers/s390/char] Error 2
>>
>> Probable cause could be commit 91570de..
>> kgdboc,keyboard: Keyboard driver for kdb with kgdb
>>
>> Thanks
>> -Sachin
>>
>>
>>
> I had patched the include/linux/keyboard.h originally to expose the
> definition which was already a global symbol. It turns out the
> kdb_keyboard.c implementation should not be accessing shift_map[]
> directly. It is accessed through a pointer to the data found in key_maps[].
>
> I folded in a change to this patch to not modify
> include/linux/keyboard.h and to fix the kdb keyboard code to use key_maps[].
>
> Hopefully that fixes the problem. Attached is the folded patch, which
> reverts include/linux/keyboard.h to be unmodified by the kdb series.
>
Yup that works. Thanks
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
prev parent reply other threads:[~2010-01-07 6:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 7:03 linux-next: Tree for January 6 Stephen Rothwell
2010-01-06 9:14 ` next Jan 6: drivers/s390/char/defkeymap build break Sachin Sant
2010-01-06 16:14 ` Jason Wessel
2010-01-07 6:03 ` Sachin Sant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B457947.2040004@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jason.wessel@windriver.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).