From: Jonathan Cameron <jic23@cam.ac.uk>
To: Jean Delvare <khali@linux-fr.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Zhang Rui <rui.zhang@intel.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next:als tree build failure
Date: Thu, 28 Jan 2010 11:59:37 +0000 [thread overview]
Message-ID: <4B617C29.6010300@cam.ac.uk> (raw)
In-Reply-To: <20100128084107.682db589@hyperion.delvare>
On 01/28/10 07:41, Jean Delvare wrote:
> On Thu, 28 Jan 2010 18:23:34 +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> Today's linux-next build (powerpc allnoconfig) failed like this:
>>
>> ld: drivers/i2c/chips/built-in.o: No such file: No such file or directory
>>
>> Caused by commit b75349f118718a435f2bb7b6e675572ecd591627 ("tsl2550: Move
>> form i2c/chips to als and update interfaces"). This removes the last
>> driver from drivers/i2c/chips/ . Maybe it needs to remove the directory
>> completely and the references to it from drivers/i2c as well.
>>
>> I have reverted that commit for today.
>
> My bad. I asked Jonathan to split the directory removal from the driver
> move for clarity. I didn't expect this to cause a build failure.
>
> Jonathan, I guess that at least the drivers/i2c/Makefile part must be
> moved back to the tsl2550 driver move patch. I leave it to you whether
> you want to move all the rest back as well, or just that part.
>
> Thanks Stephen for the heads up and sorry again for the breakage.
>
Sorry from me as well. It never occurred to me either that it might cause
a build failure.
It does make sense to keep these two steps separate. Ah well, I guess any
work around would be a pretty terrible cludge. I'll roll these two patches
back together and otherwise we will end up with something even less coherent.
Thanks,
Jonathan
next prev parent reply other threads:[~2010-01-28 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 7:23 linux-next:als tree build failure Stephen Rothwell
2010-01-28 7:41 ` Jean Delvare
2010-01-28 11:59 ` Jonathan Cameron [this message]
2010-01-28 12:17 ` Stephen Rothwell
2010-01-28 12:33 ` Jonathan Cameron
2010-01-28 12:45 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B617C29.6010300@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).