From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org, Greg KH <gregkh@suse.de>
Subject: Re: linux-next: Tree for February 15 (staging/dt3155)
Date: Mon, 15 Feb 2010 08:46:20 -0800 [thread overview]
Message-ID: <4B797A5C.8020306@oracle.com> (raw)
In-Reply-To: <20100215194926.667a3de8.sfr@canb.auug.org.au>
On 02/15/10 00:49, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20100212:
1/ dt3155 tries to use arbitrary divide & modulus. This fails on i386:
ERROR: "__udivdi3" [drivers/staging/dt3155/dt3155.ko] undefined!
ERROR: "__umoddi3" [drivers/staging/dt3155/dt3155.ko] undefined!
2/ since DT3155 depends on PCI, these lines can be dropped from dt3155_drv.c:
-#ifndef CONFIG_PCI
-#error "DT3155 : Kernel PCI support not enabled (DT3155 drive requires PCI)"
-#endif
3/ header files need to be included even when built-in instead of defined(MODULE)
to eliminate build errors:
drivers/staging/dt3155/dt3155_drv.c:1047: error: implicit declaration of function 'request_irq'
drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_SHARED' undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_DISABLED' undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1091: error: implicit declaration of function 'free_irq'
-#ifdef MODULE
#include <linux/module.h>
#include <linux/interrupt.h>
MODULE_LICENSE("GPL");
-#endif
--
~Randy
prev parent reply other threads:[~2010-02-15 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 8:49 linux-next: Tree for February 15 Stephen Rothwell
2010-02-15 16:46 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B797A5C.8020306@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).