From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: linux-next: Tree for February 19 (scsi/mpt2sas/raid_class) Date: Fri, 19 Feb 2010 09:21:50 -0800 Message-ID: <4B7EC8AE.60200@oracle.com> References: <20100219174711.5e7cc7be.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100219174711.5e7cc7be.sfr@canb.auug.org.au> Sender: linux-scsi-owner@vger.kernel.org To: Stephen Rothwell Cc: linux-next@vger.kernel.org, LKML , scsi , "James E.J. Bottomley" List-Id: linux-next.vger.kernel.org On 02/18/10 22:47, Stephen Rothwell wrote: > Hi all, > > Changes since 20100218: > > > The scsi tree lost its build failure. (caused by a one-line patch to scsi/mpt2sas/Kconfig: select RAID_ATTRS ) When CONFIG_SCSI=m, CONFIG_RAID_ATTRS can still be =y, causing build errors like: ERROR: "raid_class_release" [drivers/scsi/mpt2sas/mpt2sas.ko] undefined! ERROR: "raid_class_attach" [drivers/scsi/mpt2sas/mpt2sas.ko] undefined! drivers/scsi/built-in.o does contain raid_class_* code (according to 'nm'), but drivers/built-in.o does not, so I guess that drivers/Makefile: obj-$(CONFIG_SCSI) += scsi/ is preventing drivers/scsi/built-in.o from being added to drivers/built-in.o. We can: a/ change drivers/Makefile to say: obj-y += scsi/ (test: that still had a build error: drivers/built-in.o: In function `raid_match': raid_class.c:(.text+0x9de7c): undefined reference to `scsi_is_sdev_device' ) b/ change drivers/scsi/Kconfig to make RAID_ATTRS depend on SCSI, so that raid_class would be built as a module That one does work. Do something else? Preferences? -- ~Randy