From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linus <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org, Len Brown <lenb@kernel.org>,
Dave Jones <davej@redhat.com>, Jean Delvare <khali@linux-fr.org>,
Greg KH <greg@kroah.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
Sage Weil <sage@newdream.net>,
Christoph Lameter <cl@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Rusty Russell <rusty@rustcorp.com.au>,
Ingo Molnar <mingo@elte.hu>, Al Viro <viro@ZenIV.linux.org.uk>,
joern@logfs.org
Subject: Re: linux-next: current pending merge fix patches
Date: Mon, 01 Mar 2010 17:17:02 +0200 [thread overview]
Message-ID: <4B8BDA6E.6000902@cs.helsinki.fi> (raw)
In-Reply-To: <20100301160445.5e281f11.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> 4) The slab[7] tree adds a percpu variable usage case (commit
> 9dfc6e68bfe6ee452efb1a4e9ca26a9007f2b864 "SLUB: Use this_cpu operations in
> slub"), but the percpu[8] tree removes the prefixing of percpu variables
> (commit dd17c8f72993f9461e9c19250e3f155d6d99df22 "percpu: remove per_cpu__
> prefix"), thus the fooling patch after mergeing these trees:
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 6e34309..9e86e6b 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2071,7 +2071,7 @@ static inline int alloc_kmem_cache_cpus(struct kmem_cache *s, gfp_t flags)
> * Boot time creation of the kmalloc array. Use static per cpu data
> * since the per cpu allocator is not available yet.
> */
> - s->cpu_slab = per_cpu_var(kmalloc_percpu) + (s - kmalloc_caches);
> + s->cpu_slab = kmalloc_percpu + (s - kmalloc_caches);
> else
> s->cpu_slab = alloc_percpu(struct kmem_cache_cpu);
Thanks for the reminder Stephen! I'll add this to slab.git as soon as
the per-cpu changes land into Linus' tree.
Pekka
prev parent reply other threads:[~2010-03-01 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 5:04 linux-next: current pending merge fix patches Stephen Rothwell
2010-03-01 8:10 ` Ingo Molnar
2010-03-01 8:55 ` Stephen Rothwell
2010-03-01 9:01 ` Ingo Molnar
2010-03-01 8:56 ` Ingo Molnar
2010-03-01 9:19 ` Ingo Molnar
2010-03-01 15:17 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8BDA6E.6000902@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=bfields@fieldses.org \
--cc=cl@linux-foundation.org \
--cc=davej@redhat.com \
--cc=greg@kroah.com \
--cc=joern@logfs.org \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=sage@newdream.net \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@fys.uio.no \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox