From: Sachin Sant <sachinp@in.ibm.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: -next Apr 30: OOPS during eHEA driver initialization
Date: Sat, 01 May 2010 15:24:12 +0530 [thread overview]
Message-ID: <4BDBFA44.5080203@in.ibm.com> (raw)
In-Reply-To: <g2mfa686aa41004301043i138ffb2dmac5b641fa3d512c4@mail.gmail.com>
Grant Likely wrote:
> On Fri, Apr 30, 2010 at 11:35 AM, Grant Likely
> <grant.likely@secretlab.ca> wrote:
>
>> On Fri, Apr 30, 2010 at 11:27 AM, Sachin Sant <sachinp@in.ibm.com> wrote:
>>
>>> Sachin Sant wrote:
>>>
>>>> With today's next eHEA drivers fails to initialize.
>>>>
>>> If i revert the following patch eHEA network interface is initialized
>>> properly.
>>>
>>> commit cebfe0b6709abdab997c1a00499d67efa32ee1f0
>>> drivercore: Add of_match_table to the common device drivers
>>>
>> That is an easy one to fix. I'll get it updated today and send you the result.
>>
>
> Let me know if this patch fixes it:
>
Works for me. Thanks Grant.
Tested-by : Sachin Sant <sachinp@in.ibm.com>
Regards
-Sachin
> Cheers,
> g.
>
> diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
> index ce957a4..693b0e6 100644
> --- a/arch/powerpc/kernel/ibmebus.c
> +++ b/arch/powerpc/kernel/ibmebus.c
> @@ -201,6 +201,9 @@ static int ibmebus_create_devices(const struct
> of_device_id *matches)
>
> int ibmebus_register_driver(struct of_platform_driver *drv)
> {
> + if (!drv->driver.of_match_table)
> + drv->driver.of_match_table = drv->match_table;
> +
> /* If the driver uses devices that ibmebus doesn't know, add them */
> ibmebus_create_devices(drv->driver.of_match_table);
>
>
>
>
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
prev parent reply other threads:[~2010-05-01 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 15:12 -next Apr 30: OOPS during eHEA driver initialization Sachin Sant
2010-04-30 17:27 ` Sachin Sant
2010-04-30 17:35 ` Grant Likely
2010-04-30 17:43 ` Grant Likely
2010-05-01 9:54 ` Sachin Sant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDBFA44.5080203@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).