From: Avi Kivity <avi@redhat.com>
To: Sachin Sant <sachinp@in.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Carsten Otte <cotte@de.ibm.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-s390@vger.kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: next June 10: S390 build failure [arch/s390/kvm/kvm.ko]
Date: Wed, 23 Jun 2010 12:04:36 +0300 [thread overview]
Message-ID: <4C21CE24.2010609@redhat.com> (raw)
In-Reply-To: <4C218E7D.8070006@in.ibm.com>
On 06/23/2010 07:33 AM, Sachin Sant wrote:
> Christian Borntraeger wrote:
>> Am Donnerstag 10 Juni 2010, 15:48:48 schrieb Martin Schwidefsky:
>>> On Thu, 10 Jun 2010 18:08:15 +0530
>>> Sachin Sant <sachinp@in.ibm.com> wrote:
>>>
>>>> Today's next fails to build on a s390 box with
>>>>
>>>> ERROR: "__kvm_s390_vcpu_store_status" [arch/s390/kvm/kvm.ko]
>>>> undefined!
>>>>
>>>> Yesterday's next was good.
>>> That is caused by git commit fbc5eec58e652339e9df1332cd5e10e8d8250aaf
>>> which fails to take git commit 5288fbf0ef041ba0e8b4dcb2df4536b5e3a48b32
>>> into account. There is a second caller of __kvm_s390_vcpu_store_status
>>> in arch/s390/kvm/intercept.c. As far as I understand the code you could
>>> just drop the 'static' from kvm_s390_vcpu_store_status and call it from
>>> handle_stop instead of the old __kvm_s390_vcpu_store_status.
>>>
>>> Carsten, Christian: could one of you have a look please?
>>
>> that patch should do the trick. Avi can you add that to kvm.git?
>>
>> kvm-s390: Fix build failure
> ping on the patch. Still not merged with next.
Missed it somehow. Now applied to kvm.git next and kvm-updates/2.6.36
(which is the linux-next queue).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-06-23 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 6:00 linux-next: Tree for June 10 Stephen Rothwell
2010-06-10 12:38 ` next June 10: S390 build failure [arch/s390/kvm/kvm.ko] Sachin Sant
2010-06-10 13:48 ` Martin Schwidefsky
2010-06-12 6:54 ` Christian Borntraeger
2010-06-23 4:33 ` Sachin Sant
2010-06-23 9:04 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C21CE24.2010609@redhat.com \
--to=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sachinp@in.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).