From: Randy Dunlap <randy.dunlap@oracle.com>
To: aelder@sgi.com
Cc: "Luck, Tony" <tony.luck@intel.com>,
xfs-masters@oss.sgi.com, linux-next@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n
Date: Wed, 28 Jul 2010 10:25:49 -0700 [thread overview]
Message-ID: <4C50681D.6020306@oracle.com> (raw)
In-Reply-To: <1280326978.2238.4.camel@doink>
On 07/28/10 07:22, Alex Elder wrote:
> On Mon, 2010-07-26 at 08:48 -0700, Randy Dunlap wrote:
>> On Thu, 15 Jul 2010 10:18:07 -0700 Luck, Tony wrote:
>>
>>> When CONFIG_XFS_POSIX_ACL is not set "xfs_check_acl" is #defined
>>> to NULL - which breaks the code attempting to add a tracepoint
>>> on this function.
>>>
>>> Only define the tracepoint when the function exists.
>>>
>>> Signed-off-by: Tony Luck <tony.luck@intel.com>
>>
>> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Alex, can we get this merged for linux-next, please?
>> This problem causes lots of xfs build errors in linux-next without this patch.
>
> Confirmed fixed as of today's linux-next build. -Alex
Thanks. I'm not seeing those errors today.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2010-07-28 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 17:18 [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n Luck, Tony
2010-07-15 18:00 ` Christoph Hellwig
2010-07-15 18:06 ` Randy Dunlap
2010-07-26 15:48 ` Randy Dunlap
2010-07-28 14:22 ` Alex Elder
2010-07-28 17:25 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C50681D.6020306@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=aelder@sgi.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=linux-next@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).