linux-next: build failure after merge of the final tree (kvm tree related)

linux-next: build failure after merge of the final tree (kvm tree related)

[Stephen Rothwell]

Hi all,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

cc1: warnings being treated as errors
arch/powerpc/kvm/44x_tlb.c: In function 'kvmppc_mmu_map':
arch/powerpc/kvm/44x_tlb.c:319: error: format '%lx' expects type 'long unsigned int', but argument 2 has type 'gfn_t'

Caused by commit 05c07e00b15e00632a2502dcbf253415449e89da ("KVM: Use u64
for frame data types").  I applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 26 Jul 2010 14:25:12 +1000
Subject: [PATCH] kvm: u64's should be printed with %llx

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/kvm/44x_tlb.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kvm/44x_tlb.c b/arch/powerpc/kvm/44x_tlb.c
index 8123125..9b9b5cd 100644
--- a/arch/powerpc/kvm/44x_tlb.c
+++ b/arch/powerpc/kvm/44x_tlb.c
@@ -316,7 +316,8 @@ void kvmppc_mmu_map(struct kvm_vcpu *vcpu, u64 gvaddr, gpa_t gpaddr,
 	gfn = gpaddr >> PAGE_SHIFT;
 	new_page = gfn_to_page(vcpu->kvm, gfn);
 	if (is_error_page(new_page)) {
-		printk(KERN_ERR "Couldn't get guest page for gfn %lx!\n", gfn);
+		printk(KERN_ERR "Couldn't get guest page for gfn %llx!\n",
+			(unsigned long long)gfn);
 		kvm_release_page_clean(new_page);
 		return;
 	}
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the final tree (kvm tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

Hi Avi, Marcelo,

On Mon, 26 Jul 2010 14:27:25 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> cc1: warnings being treated as errors
> arch/powerpc/kvm/44x_tlb.c: In function 'kvmppc_mmu_map':
> arch/powerpc/kvm/44x_tlb.c:319: error: format '%lx' expects type 'long unsigned int', but argument 2 has type 'gfn_t'
> 
> Caused by commit 05c07e00b15e00632a2502dcbf253415449e89da ("KVM: Use u64
> for frame data types").  I applied the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 26 Jul 2010 14:25:12 +1000
> Subject: [PATCH] kvm: u64's should be printed with %llx

Ping?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (kvm tree related)

[Avi Kivity]

  On 08/02/2010 03:33 AM, Stephen Rothwell wrote:
>
>> From: Stephen Rothwell<sfr@canb.auug.org.au>
>> Date: Mon, 26 Jul 2010 14:25:12 +1000
>> Subject: [PATCH] kvm: u64's should be printed with %llx
> Ping?
>

Sorry.  Applied now, and will appear on next next.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

Re: linux-next: build failure after merge of the final tree (kvm tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

Hi Avi,

On Mon, 02 Aug 2010 06:40:49 +0300 Avi Kivity <avi@redhat.com> wrote:
>
> Sorry.  Applied now, and will appear on next next.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build failure after merge of the final tree (kvm tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

cc1: warnings being treated as errors
arch/powerpc/kvm/../../../virt/kvm/kvm_main.c: In function '__kvm_set_memory_region':
arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:654: error: cast to pointer from integer of different size
arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:654: error: cast to pointer from integer of different size

Caused by commit 95de6ce677d6 ("KVM: add missing void __user * cast to
access_ok() call").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (kvm tree related)

[Heiko Carstens]

On Wed, May 25, 2011 at 01:28:09PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> cc1: warnings being treated as errors
> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c: In function '__kvm_set_memory_region':
> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:654: error: cast to pointer from integer of different size
> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:654: error: cast to pointer from integer of different size
> 
> Caused by commit 95de6ce677d6 ("KVM: add missing void __user * cast to
> access_ok() call").
> 
> I have reverted that commit for today.

My fault.. sigh.

Avi could you apply the patch below as well (or merge with the previous one)?

Thanks!

Subject: [PATCH] KVM: fix userspace_addr cast in access_ok() call

From: Heiko Carstens <heiko.carstens@de.ibm.com>

mem->userspace_addr is u64. Casting that to a pointer will cause build
breakage (or warnings) on 32 bit architectures. So add an explicit
unsigned long cast as well...

Fixes this:

cc1: warnings being treated as errors
arch/powerpc/kvm/../../../virt/kvm/kvm_main.c: In function '__kvm_set_memory_region':
arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:654: error: cast to pointer from integer of different size

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
 virt/kvm/kvm_main.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -651,7 +651,8 @@ int __kvm_set_memory_region(struct kvm *
 	/* We can read the guest memory with __xxx_user() later on. */
 	if (user_alloc &&
 	    ((mem->userspace_addr & (PAGE_SIZE - 1)) ||
-	     !access_ok(VERIFY_WRITE, (void __user *)mem->userspace_addr,
+	     !access_ok(VERIFY_WRITE,
+			(void __user *)(unsigned long)mem->userspace_addr,
 			mem->memory_size)))
 		goto out;
 	if (mem->slot >= KVM_MEMORY_SLOTS + KVM_PRIVATE_MEM_SLOTS)

Re: linux-next: build failure after merge of the final tree (kvm tree related)

[Avi Kivity]

On 05/25/2011 11:02 AM, Heiko Carstens wrote:
> On Wed, May 25, 2011 at 01:28:09PM +1000, Stephen Rothwell wrote:
> >  Hi all,
> >
> >  After merging the final tree, today's linux-next build (powerpc
> >  ppc44x_defconfig) failed like this:
> >
> >  cc1: warnings being treated as errors
> >  arch/powerpc/kvm/../../../virt/kvm/kvm_main.c: In function '__kvm_set_memory_region':
> >  arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:654: error: cast to pointer from integer of different size
> >  arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:654: error: cast to pointer from integer of different size
> >
> >  Caused by commit 95de6ce677d6 ("KVM: add missing void __user * cast to
> >  access_ok() call").
> >
> >  I have reverted that commit for today.
>
> My fault.. sigh.
>
> Avi could you apply the patch below as well (or merge with the previous one)?
>

Thanks for the quick fix, applied.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

linux-next: build failure after merge of the final tree (kvm tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:

mm/memory.c: In function '__get_user_pages':
mm/memory.c:1584: error: 'EHWPOISON' undeclared (first use in this function)

Caused by commit b1c4f2836370f5c8207d4c61e91c93bd6a4ce27a ("mm: make
__get_user_pages return -EHWPOISON for HWPOISON page optionally") from
the kvm tree.

Not all architectures use include/asm-generic/errno.h ...

I have reverted that commit (and commits
d47b742c5661385b927c03188549b2d2004b80f4 "KVM: Replace
is_hwpoison_address with __get_user_pages" and
eef8839430b72deac59e9ec51eb56c44512fcc66 "mm: remove is_hwpoison_address"
which depend on it) for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (kvm tree related)

[Huang Ying]

Hi, Stephen,

On Mon, 2011-02-21 at 14:56 +0800, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
> 
> mm/memory.c: In function '__get_user_pages':
> mm/memory.c:1584: error: 'EHWPOISON' undeclared (first use in this function)
> 
> Caused by commit b1c4f2836370f5c8207d4c61e91c93bd6a4ce27a ("mm: make
> __get_user_pages return -EHWPOISON for HWPOISON page optionally") from
> the kvm tree.
> 
> Not all architectures use include/asm-generic/errno.h ...

Thanks for reminding.  Does the patch as follow fixes the issue?

Best Regards,
Huang Ying

---
 arch/alpha/include/asm/errno.h  |    2 ++
 arch/mips/include/asm/errno.h   |    2 ++
 arch/parisc/include/asm/errno.h |    2 ++
 arch/sparc/include/asm/errno.h  |    2 ++
 4 files changed, 8 insertions(+)

--- a/arch/parisc/include/asm/errno.h
+++ b/arch/parisc/include/asm/errno.h
@@ -122,4 +122,6 @@
 
 #define	ERFKILL		256	/* Operation not possible due to RF-kill */
 
+#define EHWPOISON	257	/* Memory page has hardware error */
+
 #endif
--- a/arch/sparc/include/asm/errno.h
+++ b/arch/sparc/include/asm/errno.h
@@ -112,4 +112,6 @@
 
 #define	ERFKILL		134	/* Operation not possible due to RF-kill */
 
+#define EHWPOISON	135	/* Memory page has hardware error */
+
 #endif
--- a/arch/alpha/include/asm/errno.h
+++ b/arch/alpha/include/asm/errno.h
@@ -122,4 +122,6 @@
 
 #define	ERFKILL		138	/* Operation not possible due to RF-kill */
 
+#define EHWPOISON	139	/* Memory page has hardware error */
+
 #endif
--- a/arch/mips/include/asm/errno.h
+++ b/arch/mips/include/asm/errno.h
@@ -121,6 +121,8 @@
 
 #define	ERFKILL		167	/* Operation not possible due to RF-kill */
 
+#define EHWPOISON	168	/* Memory page has hardware error */
+
 #define EDQUOT		1133	/* Quota exceeded */
 
 #ifdef __KERNEL__

Re: linux-next: build failure after merge of the final tree (kvm tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

Hi All,

On Mon, 21 Feb 2011 17:56:58 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
> 
> mm/memory.c: In function '__get_user_pages':
> mm/memory.c:1584: error: 'EHWPOISON' undeclared (first use in this function)
> 
> Caused by commit b1c4f2836370f5c8207d4c61e91c93bd6a4ce27a ("mm: make
> __get_user_pages return -EHWPOISON for HWPOISON page optionally") from
> the kvm tree.
> 
> Not all architectures use include/asm-generic/errno.h ...
> 
> I have reverted that commit (and commits
> d47b742c5661385b927c03188549b2d2004b80f4 "KVM: Replace
> is_hwpoison_address with __get_user_pages" and
> eef8839430b72deac59e9ec51eb56c44512fcc66 "mm: remove is_hwpoison_address"
> which depend on it) for today.

I am still doing those reverts ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (kvm tree related)

[Huang Ying]

Hi, Avi and Marcelo,

On Mon, 2011-02-28 at 10:15 +0800, Stephen Rothwell wrote:
> Hi All,
> 
> On Mon, 21 Feb 2011 17:56:58 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the final tree, today's linux-next build (sparc64 defconfig)
> > failed like this:
> > 
> > mm/memory.c: In function '__get_user_pages':
> > mm/memory.c:1584: error: 'EHWPOISON' undeclared (first use in this function)
> > 
> > Caused by commit b1c4f2836370f5c8207d4c61e91c93bd6a4ce27a ("mm: make
> > __get_user_pages return -EHWPOISON for HWPOISON page optionally") from
> > the kvm tree.
> > 
> > Not all architectures use include/asm-generic/errno.h ...
> > 
> > I have reverted that commit (and commits
> > d47b742c5661385b927c03188549b2d2004b80f4 "KVM: Replace
> > is_hwpoison_address with __get_user_pages" and
> > eef8839430b72deac59e9ec51eb56c44512fcc66 "mm: remove is_hwpoison_address"
> > which depend on it) for today.
> 
> I am still doing those reverts ...

Can you merge the fixes following the email into my original EHWPOISON
patch to check if that fixes linux-next issue?

Or you prefer I resend the patchset?

Best Regards,
Huang Ying

---
 arch/alpha/include/asm/errno.h  |    2 ++
 arch/mips/include/asm/errno.h   |    2 ++
 arch/parisc/include/asm/errno.h |    2 ++
 arch/sparc/include/asm/errno.h  |    2 ++
 4 files changed, 8 insertions(+)

--- a/arch/parisc/include/asm/errno.h
+++ b/arch/parisc/include/asm/errno.h
@@ -122,4 +122,6 @@
 
 #define	ERFKILL		256	/* Operation not possible due to RF-kill */
 
+#define EHWPOISON	257	/* Memory page has hardware error */
+
 #endif
--- a/arch/sparc/include/asm/errno.h
+++ b/arch/sparc/include/asm/errno.h
@@ -112,4 +112,6 @@
 
 #define	ERFKILL		134	/* Operation not possible due to RF-kill */
 
+#define EHWPOISON	135	/* Memory page has hardware error */
+
 #endif
--- a/arch/alpha/include/asm/errno.h
+++ b/arch/alpha/include/asm/errno.h
@@ -122,4 +122,6 @@
 
 #define	ERFKILL		138	/* Operation not possible due to RF-kill */
 
+#define EHWPOISON	139	/* Memory page has hardware error */
+
 #endif
--- a/arch/mips/include/asm/errno.h
+++ b/arch/mips/include/asm/errno.h
@@ -121,6 +121,8 @@
 
 #define	ERFKILL		167	/* Operation not possible due to RF-kill */
 
+#define EHWPOISON	168	/* Memory page has hardware error */
+
 #define EDQUOT		1133	/* Quota exceeded */
 
 #ifdef __KERNEL__

Re: linux-next: build failure after merge of the final tree (kvm tree related)

[Avi Kivity]

On 02/28/2011 04:28 AM, Huang Ying wrote:
> Hi, Avi and Marcelo,
>
> On Mon, 2011-02-28 at 10:15 +0800, Stephen Rothwell wrote:
> >  Hi All,
> >
> >  On Mon, 21 Feb 2011 17:56:58 +1100 Stephen Rothwell<sfr@canb.auug.org.au>  wrote:
> >  >
> >  >  After merging the final tree, today's linux-next build (sparc64 defconfig)
> >  >  failed like this:
> >  >
> >  >  mm/memory.c: In function '__get_user_pages':
> >  >  mm/memory.c:1584: error: 'EHWPOISON' undeclared (first use in this function)
> >  >
> >  >  Caused by commit b1c4f2836370f5c8207d4c61e91c93bd6a4ce27a ("mm: make
> >  >  __get_user_pages return -EHWPOISON for HWPOISON page optionally") from
> >  >  the kvm tree.
> >  >
> >  >  Not all architectures use include/asm-generic/errno.h ...
> >  >
> >  >  I have reverted that commit (and commits
> >  >  d47b742c5661385b927c03188549b2d2004b80f4 "KVM: Replace
> >  >  is_hwpoison_address with __get_user_pages" and
> >  >  eef8839430b72deac59e9ec51eb56c44512fcc66 "mm: remove is_hwpoison_address"
> >  >  which depend on it) for today.
> >
> >  I am still doing those reverts ...
>
> Can you merge the fixes following the email into my original EHWPOISON
> patch to check if that fixes linux-next issue?
>

I folded this into the original patch, will show up in next linux-next.

-- 
error compiling committee.c: too many arguments to function

linux-next: build failure after merge of the final tree (kvm tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

Hi all,

After merging the final tree, the next-20100831 (and later) build
(powerpc allmodconfig) failed like this:

include/asm/kvm_para.h:24: included file 'linux/of.h' is not exported

Caused by commit 6e13db5991fea393973f284ec3e951ae8ac3795c ("KVM: PPC:
Implement hypervisor interface").  The include of linux/of.h needs to be
protected by __KERNEL__ .

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build failure after merge of the final tree (kvm tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc ppc44x_defconfig)
failed like this:

arch/powerpc/kvm/built-in.o: In function `kvm_vcpu_ioctl_interrupt':
(.text+0x4840): undefined reference to `kvmppc_core_dequeue_external'

Caused by commit 6fc1eb3ee0ad1667b217d993e9bd26089f2b0b32 ("KVM: PPC:
Allow userspace to unset the IRQ line") from the kvm tree.  I guess an
implementation was forgotten.

I reverted the whole kvm tree for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]