From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [PATCH -next] optprobes: fix kconfig depends/selects Date: Tue, 17 Aug 2010 23:55:27 +0900 Message-ID: <4C6AA2DF.5020301@hitachi.com> References: <20100812122641.fe88e846.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100812122641.fe88e846.randy.dunlap@oracle.com> Sender: linux-kernel-owner@vger.kernel.org To: Randy Dunlap Cc: lkml , linux-next@vger.kernel.org, Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" , akpm List-Id: linux-next.vger.kernel.org Randy Dunlap wrote: > From: Randy Dunlap > > KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. > KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. Indeed, Thanks for pointing it! Signed-off-by: Masami Hiramatsu > > warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) > > Signed-off-by: Randy Dunlap > Cc: Ananth N Mavinakayanahalli > Cc: Anil S Keshavamurthy > Cc: "David S. Miller" > Cc: Masami Hiramatsu > --- > arch/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20100810.orig/arch/Kconfig > +++ linux-next-20100810/arch/Kconfig > @@ -45,6 +45,8 @@ config OPTPROBES > def_bool y > depends on KPROBES && HAVE_OPTPROBES > depends on !PREEMPT > + depends on DEBUG_KERNEL > + select KALLSYMS > select KALLSYMS_ALL > > config HAVE_EFFICIENT_UNALIGNED_ACCESS