From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again Date: Tue, 17 Aug 2010 11:03:39 -0700 Message-ID: <4C6ACEFB.7060706@oracle.com> References: <20100809132314.789e13f3.sfr@canb.auug.org.au> <201008101416.31188.laurent.pinchart@ideasonboard.com> <4C6166D9.60607@oracle.com> <201008101653.08358.laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201008101653.08358.laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laurent Pinchart Cc: Stephen Rothwell , gregkh-l3A5Bk7waGM@public.gmane.org, lud , linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , David Brownell List-Id: linux-next.vger.kernel.org On 08/10/10 07:53, Laurent Pinchart wrote: > Hi Randy, > > On Tuesday 10 August 2010 16:48:57 Randy Dunlap wrote: >> On 08/10/10 05:16, Laurent Pinchart wrote: >>> On Monday 09 August 2010 19:55:20 Randy Dunlap wrote: >>>> From: Randy Dunlap >>>> >>>> The USB gadget webcam driver uses V4L2 interfaces, so it should depend >>>> on VIDEO_V4L2 instead of VIDEO_DEV. This fixes a lot of build errors >>>> when V4L2 is not enabled: >>>> >>>> ERROR: "v4l2_event_unsubscribe" [drivers/usb/gadget/g_webcam.ko] >>>> undefined! ERROR: "v4l2_event_queue" [drivers/usb/gadget/g_webcam.ko] >>>> undefined! ERROR: "video_device_release" >>>> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: "video_usercopy" >>>> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: "v4l2_event_dequeue" >>>> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: >>>> "video_register_device" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "video_device_alloc" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_event_subscribe" [drivers/usb/gadget/g_webcam.ko] >>>> undefined! ERROR: "video_unregister_device" >>>> [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_fh_init" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_event_pending" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_event_init" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "video_devdata" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_event_alloc" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_fh_add" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_fh_del" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_fh_exit" [drivers/usb/gadget/g_webcam.ko] undefined! >>> >>> All those symbols should be defined when VIDEO_DEV is selected. >>> >>>> ERROR: "v4l2_ctrl_fill" [drivers/media/video/v4l2-common.ko] undefined! >>>> ERROR: "v4l2_ctrl_get_menu" [drivers/media/video/v4l2-common.ko] >>>> undefined! >>> >>> Those 2 symbols require VIDEO_V4L2 but are not used by the webcam gadget >>> driver. >>> >>>> ERROR: "v4l2_device_unregister_subdev" >>>> [drivers/media/video/v4l2-common.ko] undefined! >>>> ERROR: "v4l2_device_register_subdev" >>>> [drivers/media/video/v4l2-common.ko] undefined! >>> >>> Those two symbols should be defined when VIDEO_DEV is selected. They are >>> not used by the webcam gadget driver. >> >> Summary: I should drop this patch and look elsewhere for the problem, >> Right? > > I think the problem comes from somewhere else, yes. Your patch won't hurt, but > I don't see how it could fix the problem either. Agreed. Patch is withdrawn. Thanks. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html