From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH -next,-tip ] kprobes: Fix Kconfig dependency Date: Mon, 13 Sep 2010 09:33:48 -0700 Message-ID: <4C8E526C.8000209@oracle.com> References: <4C8DCFAE.4020700@hitachi.com> <20100913102541.20260.85700.stgit@ltc236.sdl.hitachi.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:60001 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250Ab0IMQkI (ORCPT ); Mon, 13 Sep 2010 12:40:08 -0400 In-Reply-To: <20100913102541.20260.85700.stgit@ltc236.sdl.hitachi.co.jp> Sender: linux-next-owner@vger.kernel.org List-ID: To: Masami Hiramatsu Cc: Ingo Molnar , Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org, 2nddept-manager@sdl.hitachi.co.jp, Felipe Contreras , linux-next@vger.kernel.org, Anil S Keshavamurthy , "David S. Miller" , akpm On 09/13/10 03:25, Masami Hiramatsu wrote: > Fix Kconfig dependency among Kprobes, optprobe and kallsyms. > > Kprobes uses kallsyms_lookup for finding target function and checking > instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS. > > Optprobe is an optional feature which is supported on x86 arch, and > it also uses kallsyms_lookup for checking instructions in the target > function. Since KALLSYMS_ALL just adds symbols of kernel variables, > it doesn't need to select KALLSYMS_ALL. > > Signed-off-by: Masami Hiramatsu > Cc: Felipe Contreras > Cc: Randy Dunlap , > Cc: linux-kernel@vger.kernel.org, > Cc: linux-next@vger.kernel.org, > Cc: Ananth N Mavinakayanahalli , > Cc: Anil S Keshavamurthy , > Cc: "David S. Miller" , > Cc: akpm > --- > > arch/Kconfig | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 4877a8c..fe48fc7 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -32,8 +32,9 @@ config HAVE_OPROFILE > > config KPROBES > bool "Kprobes" > - depends on KALLSYMS && MODULES > + depends on MODULES > depends on HAVE_KPROBES > + select KALLSYMS > help > Kprobes allows you to trap at almost any kernel address and > execute a callback function. register_kprobe() establishes > @@ -45,7 +46,6 @@ config OPTPROBES > def_bool y > depends on KPROBES && HAVE_OPTPROBES > depends on !PREEMPT > - select KALLSYMS_ALL > > config HAVE_EFFICIENT_UNALIGNED_ACCESS > bool > Fixes the kconfig dependency problem. Thanks. Acked-by: Randy Dunlap -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***