From: Sachin Sant <sachinp@in.ibm.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-s390@vger.kernel.org,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Re: [-next Sept 10] Build break - arch/s390/mm/pgtable.c (INIT_RCU_HEAD)
Date: Tue, 14 Sep 2010 13:43:51 +0530 [thread overview]
Message-ID: <4C8F2EBF.4060606@in.ibm.com> (raw)
In-Reply-To: <20100910122806.05548325@mschwide.boeblingen.de.ibm.com>
Martin Schwidefsky wrote:
> On Fri, 10 Sep 2010 13:43:20 +0530
> Sachin Sant <sachinp@in.ibm.com> wrote:
>
>
>> Today's next fails to build on a s390 box with
>>
>> arch/s390/mm/pgtable.c: In function 'rcu_table_freelist_finish':
>> arch/s390/mm/pgtable.c:79: error: implicit declaration of function 'INIT_RCU_HEAD'
>> make[2]: *** [arch/s390/mm/pgtable.o] Error 1
>>
>> This code in question was added via following commit:
>>
>> commit e726023d9ff7e4968e3e0622782174a4695d68a4
>> S390] lockless get_user_pages_fast()
>>
>
> I guess that there is an #include <linux/rcupdate.h> missing in pgtable.c. I'll
> add it to the patch.
>
I don't see definition for INIT_RCU_HEAD in rcupdate.h so adding rcupdate.h might
not help.
Infact i can't find usage/implementation of INIT_RCU_HEAD anywhere else in the code.
Is this macro deprecated ?
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
next prev parent reply other threads:[~2010-09-14 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 8:13 [-next Sept 10] Build break - arch/s390/mm/pgtable.c (INIT_RCU_HEAD) Sachin Sant
2010-09-10 10:28 ` Martin Schwidefsky
2010-09-14 8:13 ` Sachin Sant [this message]
2010-09-14 8:36 ` Stephen Rothwell
2010-09-14 11:39 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8F2EBF.4060606@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox