From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sachin Sant Subject: Re: [-next Sept 10] Build break - arch/s390/mm/pgtable.c (INIT_RCU_HEAD) Date: Tue, 14 Sep 2010 13:43:51 +0530 Message-ID: <4C8F2EBF.4060606@in.ibm.com> References: <4C89E8A0.1050905@in.ibm.com> <20100910122806.05548325@mschwide.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from e23smtp04.au.ibm.com ([202.81.31.146]:48274 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062Ab0ININz (ORCPT ); Tue, 14 Sep 2010 04:13:55 -0400 In-Reply-To: <20100910122806.05548325@mschwide.boeblingen.de.ibm.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Martin Schwidefsky Cc: linux-s390@vger.kernel.org, "linux-next@vger.kernel.org" Martin Schwidefsky wrote: > On Fri, 10 Sep 2010 13:43:20 +0530 > Sachin Sant wrote: > > >> Today's next fails to build on a s390 box with >> >> arch/s390/mm/pgtable.c: In function 'rcu_table_freelist_finish': >> arch/s390/mm/pgtable.c:79: error: implicit declaration of function 'INIT_RCU_HEAD' >> make[2]: *** [arch/s390/mm/pgtable.o] Error 1 >> >> This code in question was added via following commit: >> >> commit e726023d9ff7e4968e3e0622782174a4695d68a4 >> S390] lockless get_user_pages_fast() >> > > I guess that there is an #include missing in pgtable.c. I'll > add it to the patch. > I don't see definition for INIT_RCU_HEAD in rcupdate.h so adding rcupdate.h might not help. Infact i can't find usage/implementation of INIT_RCU_HEAD anywhere else in the code. Is this macro deprecated ? Thanks -Sachin -- --------------------------------- Sachin Sant IBM Linux Technology Center India Systems and Technology Labs Bangalore, India ---------------------------------