* [PATCH -next] hwmon/pkgtemp: fix build error
2010-09-28 4:18 linux-next: Tree for September 28 Stephen Rothwell
@ 2010-09-28 16:48 ` Randy Dunlap
2010-09-28 16:53 ` [PATCH -next] ceph: fix debugfs warnings Randy Dunlap
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2010-09-28 16:48 UTC (permalink / raw)
To: Stephen Rothwell, Fenghua Yu; +Cc: linux-next, LKML
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix build error and config symbol comment:
drivers/hwmon/pkgtemp.c:413: error:'pkgtemp_cpu_notifier' undeclared (first use in this function)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/hwmon/pkgtemp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-next-20100928.orig/drivers/hwmon/pkgtemp.c
+++ linux-next-20100928/drivers/hwmon/pkgtemp.c
@@ -386,7 +386,7 @@ static int __cpuinit pkgtemp_cpu_callbac
static struct notifier_block pkgtemp_cpu_notifier __refdata = {
.notifier_call = pkgtemp_cpu_callback,
};
-#endif /* !CONFIG_HOTPLUG_CPU */
+#endif /* CONFIG_HOTPLUG_CPU */
static int __init pkgtemp_init(void)
{
@@ -408,9 +408,9 @@ static int __init pkgtemp_init(void)
err = -ENODEV;
goto exit_driver_unreg;
}
-#endif
-
+#else
register_hotcpu_notifier(&pkgtemp_cpu_notifier);
+#endif
return 0;
#ifndef CONFIG_HOTPLUG_CPU
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH -next] ceph: fix debugfs warnings
2010-09-28 4:18 linux-next: Tree for September 28 Stephen Rothwell
2010-09-28 16:48 ` [PATCH -next] hwmon/pkgtemp: fix build error Randy Dunlap
@ 2010-09-28 16:53 ` Randy Dunlap
2010-09-28 19:42 ` Sage Weil
2010-09-28 16:54 ` [PATCH -next] fs.h: fix functions for FILE_LOCKING disabled Randy Dunlap
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2010-09-28 16:53 UTC (permalink / raw)
To: Stephen Rothwell, Sage Weil; +Cc: linux-next, LKML, ceph-devel
From: Randy Dunlap <randy.dunlap@oracle.com>
Include "super.h" outside of CONFIG_DEBUG_FS to eliminate a compiler warning:
fs/ceph/debugfs.c:266: warning: 'struct ceph_fs_client' declared inside parameter list
fs/ceph/debugfs.c:266: warning: its scope is only this definition or declaration, which is probably not what you want
fs/ceph/debugfs.c:271: warning: 'struct ceph_fs_client' declared inside parameter list
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
fs/ceph/debugfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20100927.orig/fs/ceph/debugfs.c
+++ linux-next-20100927/fs/ceph/debugfs.c
@@ -12,9 +12,10 @@
#include <linux/ceph/auth.h>
#include <linux/ceph/debugfs.h>
+#include "super.h"
+
#ifdef CONFIG_DEBUG_FS
-#include "super.h"
#include "mds_client.h"
static int mdsmap_show(struct seq_file *s, void *p)
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH -next] ceph: fix debugfs warnings
2010-09-28 16:53 ` [PATCH -next] ceph: fix debugfs warnings Randy Dunlap
@ 2010-09-28 19:42 ` Sage Weil
0 siblings, 0 replies; 10+ messages in thread
From: Sage Weil @ 2010-09-28 19:42 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, linux-next, LKML, ceph-devel
Thanks, Randy. This is in my for-next branch now!
sage
On Tue, 28 Sep 2010, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Include "super.h" outside of CONFIG_DEBUG_FS to eliminate a compiler warning:
>
> fs/ceph/debugfs.c:266: warning: 'struct ceph_fs_client' declared inside parameter list
> fs/ceph/debugfs.c:266: warning: its scope is only this definition or declaration, which is probably not what you want
> fs/ceph/debugfs.c:271: warning: 'struct ceph_fs_client' declared inside parameter list
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> fs/ceph/debugfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20100927.orig/fs/ceph/debugfs.c
> +++ linux-next-20100927/fs/ceph/debugfs.c
> @@ -12,9 +12,10 @@
> #include <linux/ceph/auth.h>
> #include <linux/ceph/debugfs.h>
>
> +#include "super.h"
> +
> #ifdef CONFIG_DEBUG_FS
>
> -#include "super.h"
> #include "mds_client.h"
>
> static int mdsmap_show(struct seq_file *s, void *p)
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -next] fs.h: fix functions for FILE_LOCKING disabled
2010-09-28 4:18 linux-next: Tree for September 28 Stephen Rothwell
2010-09-28 16:48 ` [PATCH -next] hwmon/pkgtemp: fix build error Randy Dunlap
2010-09-28 16:53 ` [PATCH -next] ceph: fix debugfs warnings Randy Dunlap
@ 2010-09-28 16:54 ` Randy Dunlap
2010-09-28 16:56 ` [PATCH -next] pch_gbe: add header files Randy Dunlap
2010-09-28 16:58 ` [PATCH -next] sound/soc: fix printk format warning Randy Dunlap
4 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2010-09-28 16:54 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, LKML
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix function signature warning when CONFIG_FILE_LOCKING is disabled.
include/linux/fs.h:1275: warning: function declaration isn't a prototype
include/linux/fs.h:1279: warning: function declaration isn't a prototype
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
include/linux/fs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20100927.orig/include/linux/fs.h
+++ linux-next-20100927/include/linux/fs.h
@@ -1271,11 +1271,11 @@ static inline int lock_may_write(struct
return 1;
}
-static inline void lock_flocks()
+static inline void lock_flocks(void)
{
}
-static inline void unlock_flocks()
+static inline void unlock_flocks(void)
{
}
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH -next] pch_gbe: add header files
2010-09-28 4:18 linux-next: Tree for September 28 Stephen Rothwell
` (2 preceding siblings ...)
2010-09-28 16:54 ` [PATCH -next] fs.h: fix functions for FILE_LOCKING disabled Randy Dunlap
@ 2010-09-28 16:56 ` Randy Dunlap
2010-09-28 17:34 ` David Miller
2010-09-28 16:58 ` [PATCH -next] sound/soc: fix printk format warning Randy Dunlap
4 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2010-09-28 16:56 UTC (permalink / raw)
To: Stephen Rothwell, netdev, davem; +Cc: linux-next, LKML, masa-korg
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix build errors, more header files needed.
drivers/net/pch_gbe/pch_gbe_main.c:965: error: implicit declaration of function 'tcp_hdr'
drivers/net/pch_gbe/pch_gbe_main.c:965: error: invalid type argument of '->' (have 'int')
drivers/net/pch_gbe/pch_gbe_main.c:968: error: invalid type argument of '->' (have 'int')
drivers/net/pch_gbe/pch_gbe_main.c:976: error: implicit declaration of function 'udp_hdr'
drivers/net/pch_gbe/pch_gbe_main.c:976: error: invalid type argument of '->' (have 'int')
drivers/net/pch_gbe/pch_gbe_main.c:980: error: invalid type argument of '->' (have 'int')
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/pch_gbe/pch_gbe.h | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20100927.orig/drivers/net/pch_gbe/pch_gbe.h
+++ linux-next-20100927/drivers/net/pch_gbe/pch_gbe.h
@@ -31,6 +31,8 @@
#include <linux/ethtool.h>
#include <linux/vmalloc.h>
#include <net/ip.h>
+#include <net/tcp.h>
+#include <net/udp.h>
/**
* pch_gbe_regs_mac_adr - Structure holding values of mac address registers
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH -next] pch_gbe: add header files
2010-09-28 16:56 ` [PATCH -next] pch_gbe: add header files Randy Dunlap
@ 2010-09-28 17:34 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2010-09-28 17:34 UTC (permalink / raw)
To: randy.dunlap; +Cc: sfr, netdev, linux-next, linux-kernel, masa-korg
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Tue, 28 Sep 2010 09:56:43 -0700
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix build errors, more header files needed.
>
> drivers/net/pch_gbe/pch_gbe_main.c:965: error: implicit declaration of function 'tcp_hdr'
> drivers/net/pch_gbe/pch_gbe_main.c:965: error: invalid type argument of '->' (have 'int')
> drivers/net/pch_gbe/pch_gbe_main.c:968: error: invalid type argument of '->' (have 'int')
> drivers/net/pch_gbe/pch_gbe_main.c:976: error: implicit declaration of function 'udp_hdr'
> drivers/net/pch_gbe/pch_gbe_main.c:976: error: invalid type argument of '->' (have 'int')
> drivers/net/pch_gbe/pch_gbe_main.c:980: error: invalid type argument of '->' (have 'int')
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Applied, thanks Randy.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -next] sound/soc: fix printk format warning
2010-09-28 4:18 linux-next: Tree for September 28 Stephen Rothwell
` (3 preceding siblings ...)
2010-09-28 16:56 ` [PATCH -next] pch_gbe: add header files Randy Dunlap
@ 2010-09-28 16:58 ` Randy Dunlap
2010-09-28 17:33 ` Mark Brown
4 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2010-09-28 16:58 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, LKML, Liam Girdwood, Mark Brown
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix dev_printk format warning:
sound/soc/codecs/wm8985.c:731: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
sound/soc/codecs/wm8985.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20100927.orig/sound/soc/codecs/wm8985.c
+++ linux-next-20100927/sound/soc/codecs/wm8985.c
@@ -728,7 +728,7 @@ static int wm8985_hw_params(struct snd_p
return -EINVAL;
}
- dev_dbg(dai->dev, "BCLK div = %d\n", i);
+ dev_dbg(dai->dev, "BCLK div = %zd\n", i);
snd_soc_update_bits(codec, WM8985_CLOCK_GEN_CONTROL,
WM8985_BCLKDIV_MASK, i << WM8985_BCLKDIV_SHIFT);
return 0;
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH -next] sound/soc: fix printk format warning
2010-09-28 16:58 ` [PATCH -next] sound/soc: fix printk format warning Randy Dunlap
@ 2010-09-28 17:33 ` Mark Brown
2010-09-28 17:41 ` Randy Dunlap
0 siblings, 1 reply; 10+ messages in thread
From: Mark Brown @ 2010-09-28 17:33 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, linux-next, LKML, Liam Girdwood
On Tue, Sep 28, 2010 at 09:58:46AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Fix dev_printk format warning:
> sound/soc/codecs/wm8985.c:731: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Takashi already fixed that (and the change already seems to be in
-next...).
When reporting type based warnings please always report the
architecture you're building for, GCC seems to only generate the
warnings if there's a difference in the underlying typedef which means
that they don't always trigger on every architecture.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH -next] sound/soc: fix printk format warning
2010-09-28 17:33 ` Mark Brown
@ 2010-09-28 17:41 ` Randy Dunlap
0 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2010-09-28 17:41 UTC (permalink / raw)
To: Mark Brown; +Cc: Stephen Rothwell, linux-next, LKML, Liam Girdwood
On 09/28/10 10:33, Mark Brown wrote:
> On Tue, Sep 28, 2010 at 09:58:46AM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>
>> Fix dev_printk format warning:
>
>> sound/soc/codecs/wm8985.c:731: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> Takashi already fixed that (and the change already seems to be in
> -next...).
I don't see the fix in linux-next 2010-0928.
Aha, he changed the variable type. OK, thanks.
> When reporting type based warnings please always report the
> architecture you're building for, GCC seems to only generate the
> warnings if there's a difference in the underlying typedef which means
> that they don't always trigger on every architecture.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 10+ messages in thread