From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: linux-next: build failure after merge of the final tree (v4l-dvb tree related) Date: Thu, 21 Oct 2010 08:53:45 -0200 Message-ID: <4CC01BB9.6040609@infradead.org> References: <20101019180730.5beac8af.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from casper.infradead.org ([85.118.1.10]:53593 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753447Ab0JUKxz (ORCPT ); Thu, 21 Oct 2010 06:53:55 -0400 In-Reply-To: <20101019180730.5beac8af.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Palash Bandyopadhyay , Devin Heitmueller , Arnd Bergmann Hi Stephen, Em 19-10-2010 05:07, Stephen Rothwell escreveu: > Hi Mauro, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/media/video/cx231xx/cx231xx-417.c: In function 'cx231xx_load_firmware': > drivers/media/video/cx231xx/cx231xx-417.c:943: error: implicit declaration of function 'vmalloc' > drivers/media/video/cx231xx/cx231xx-417.c:943: warning: cast to pointer from integer of different size > drivers/media/video/cx231xx/cx231xx-417.c:950: warning: cast to pointer from integer of different size > drivers/media/video/cx231xx/cx231xx-417.c:1039: error: implicit declaration of function 'vfree' > > Caused by commit e0bb3704be9decb10985b0886031e76a228b5f32 ("[media] > cx231xx: Added support for Carraera, Shelby, RDx_253S and VIDEO_GRABBER"). > > > I added the following patch for today: Thanks, I'm adding it to my tree. It seems that some header conditionally includes vmalloc.h or slab.h. At least, on my builds here with i386 and allyesconfig, no build errors appeared. > Also, I don't think Arnd is going to like the new BKL usage also > introduced by the commit. ;-) Yeah. Well, v4l is already on his list of BKL troubles. We're already addressing those issues. We should have a BKL-free version of cx231xx-417.c for 2.6.38. Cheers, Mauro.