From: Randy Dunlap <randy.dunlap@oracle.com>
To: "R.M. Thomas" <rmthomas@sciolus.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
gregkh@suse.de
Subject: Re: [PATCH -next] staging/easycap: make module params private/static, fix build
Date: Thu, 11 Nov 2010 14:18:12 -0800 [thread overview]
Message-ID: <4CDC6BA4.3060307@oracle.com> (raw)
In-Reply-To: <4CDC67FF.3010006@sciolus.org>
On 11/11/10 14:02, R.M. Thomas wrote:
> Randy Dunlap wrote:
>> The easycap driver has module parameters (bars, gain, & debug)
>> with global scope that intrude on the kernel namespace and cause
>> build problems. Change the names of them to be driver-specific
>> and make 2 of them static.
>
> I did do test builds of the driver in-tree prior to submitting the
> recent set of patches, but did not see any warnings so did not spot
> this mistake. There's presumably something wrong with the way I'm
> building the kernel.
This build problem shows up when this driver is built into the kernel
image, not built as a loadable module. Did you only build as a loadable
module, maybe? and what CPU architecture did you build for? That could
also matter.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-11-11 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 1:56 linux-next: Tree for November 11 Stephen Rothwell
2010-11-11 17:48 ` linux-next: Tree for November 11 (unifdef) Randy Dunlap
2010-11-11 18:26 ` Tony Finch
2010-11-11 18:44 ` [PATCH -next] staging/easycap: make module params private/static, fix build Randy Dunlap
2010-11-11 22:02 ` R.M. Thomas
2010-11-11 22:18 ` Randy Dunlap [this message]
2010-11-12 10:30 ` R.M. Thomas
2010-11-12 22:47 ` [PATCH -next] staging: fix ste_rmi4 build, depends on INPUT Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDC6BA4.3060307@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rmthomas@sciolus.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).