From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH -next] xen: fix header export to userspace Date: Mon, 15 Nov 2010 10:15:43 -0800 Message-ID: <4CE178CF.3020308@goop.org> References: <20101112130547.c2a3c2c1.sfr@canb.auug.org.au> <20101113084439.d21bd0f0.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101113084439.d21bd0f0.randy.dunlap@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Randy Dunlap Cc: Stephen Rothwell , "xen-devel@lists.xensource.com" , Konrad Rzeszutek Wilk , Tony Finch , LKML , "virtualization@lists.osdl.org" , "linux-next@vger.kernel.org" , akpm List-Id: linux-next.vger.kernel.org On 11/13/2010 08:44 AM, Randy Dunlap wrote: > From: Randy Dunlap > > scripts/headers_install.pl prevents "__user" from being exported > to userspace headers, so just use compiler.h to make sure that > __user is defined and avoid the error. > > unifdef: linux-next-20101112/xx64/usr/include/xen/privcmd.h.tmp: 79: Premature EOF (#if line 33 depth 1) Ah, OK, thanks. I was wondering what the proper fix for this was. I'll stick this in my tree. Thanks, J > Signed-off-by: Randy Dunlap > Cc: Jeremy Fitzhardinge > Cc: Konrad Rzeszutek Wilk > Cc: xen-devel@lists.xensource.com (moderated for non-subscribers) > Cc: virtualization@lists.osdl.org > Cc: Tony Finch > --- > include/xen/privcmd.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > --- linux-next-20101112.orig/include/xen/privcmd.h > +++ linux-next-20101112/include/xen/privcmd.h > @@ -34,13 +34,10 @@ > #define __LINUX_PUBLIC_PRIVCMD_H__ > > #include > +#include > > typedef unsigned long xen_pfn_t; > > -#ifndef __user > -#define __user > -#endif > - > struct privcmd_hypercall { > __u64 op; > __u64 arg[5];