From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: linux-next: Tree for November 17 Date: Wed, 17 Nov 2010 15:24:51 -0800 Message-ID: <4CE46443.2000002@oracle.com> References: <20101117140956.a8264c75.sfr@canb.auug.org.au> <20101117095920.2b9e2e6a.randy.dunlap@oracle.com> <20101118101459.472d540b.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:37452 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109Ab0KQX1E (ORCPT ); Wed, 17 Nov 2010 18:27:04 -0500 In-Reply-To: <20101118101459.472d540b.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: Zimny Lech , linux-next@vger.kernel.org, LKML , Arnd Bergmann , Linus On 11/17/10 15:14, Stephen Rothwell wrote: > On Wed, 17 Nov 2010 09:59:20 -0800 Randy Dunlap wrote: >> >> Why was #include removed from ? >> >> I added #include to i387.h, but them mm/filemap.c build fails >> with the same error: >> >> linux-next-20101117/mm/filemap.c: In function 'iov_iter_copy_from_user_atomic': >> linux-next-20101117/mm/filemap.c:1936: error: implicit declaration of function 'kernel_locked' > > Was this fixed before Linus took that patch? Also, the #include of This build error was in linux-next of NOV. 17. What mainline base did it use? I don't exactly know how to answer your question... > linux/smp_lock.h in linux/hardirq.h was the only line between #ifdef > CONFIG_PREEMPT and #endif ... was this patch even reviewed? > > Maybe (after it was reviewed) it should have been given more time in > linux-next before being merged. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***