From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for November 23 (sep_driver)
Date: Tue, 23 Nov 2010 16:18:19 -0800 [thread overview]
Message-ID: <4CEC59CB.1010105@oracle.com> (raw)
In-Reply-To: <20101123140609.2b6503ff.sfr@canb.auug.org.au>
On Tue, 23 Nov 2010 14:06:09 +1100 Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20101122:
sep_driver build on x86_64 gets lots of printk format warnings.
There are 2 categories of these warnings.
(a) using %x for a size_t, when it should be %zx
(b) using %x for some _IOW() constant: no warning on i386, but
x86_64 says:
drivers/staging/sep/sep_driver.c:3415: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'
where lines 3415-3416 are:
dev_dbg(&sep->pdev->dev,
"SEP_IOCPREPAREDCB is %x\n", SEP_IOCPREPAREDCB);
Changing that to:
dev_dbg(&sep->pdev->dev,
"SEP_IOCPREPAREDCB is %lx\n", (unsigned long)SEP_IOCPREPAREDCB);
obviously fixes the printk format warning, but is there a better solution?
thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-11-24 0:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 3:06 linux-next: Tree for November 23 Stephen Rothwell
2010-11-23 15:43 ` Zimny Lech
2010-11-23 17:15 ` Randy Dunlap
2010-11-23 19:03 ` Zimny Lech
2010-11-23 19:04 ` Zimny Lech
2010-11-23 19:41 ` linux-next: Tree for November 23 (randconfig problem?) Randy Dunlap
2010-11-23 15:45 ` linux-next: Tree for November 23 Zimny Lech
2010-11-23 16:32 ` Anca Emanuel
2010-11-23 17:11 ` Anca Emanuel
2010-11-25 5:58 ` Stephen Rothwell
2010-11-23 17:38 ` linux-next: Tree for November 23 (vmxnet3) Randy Dunlap
2010-11-24 0:18 ` Randy Dunlap [this message]
2010-11-24 9:24 ` linux-next: Tree for November 23 Zimny Lech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEC59CB.1010105@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).