From: Randy Dunlap <randy.dunlap@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
akpm <akpm@linux-foundation.org>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andres Salomon <dilinger@collabora.co.uk>
Subject: Re: [PATCH V2 -next] cs5535: fix printk format warnings
Date: Mon, 13 Dec 2010 12:42:19 -0800 [thread overview]
Message-ID: <4D06852B.8030409@oracle.com> (raw)
In-Reply-To: <1292272085.26970.50.camel@Joe-Laptop>
On 12/13/10 12:28, Joe Perches wrote:
> Use vsprintf extension %pR to format resource.
>
> Original-patch-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Joe Perches <joe@perches.com>
>
> ---
>
> drivers/gpio/cs5535-gpio.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/cs5535-gpio.c b/drivers/gpio/cs5535-gpio.c
> index b566fd5e..d7da7a1 100644
> --- a/drivers/gpio/cs5535-gpio.c
> +++ b/drivers/gpio/cs5535-gpio.c
> @@ -266,8 +266,7 @@ static int __devinit cs5535_gpio_probe(struct platform_device *pdev)
> cs5535_gpio_chip.pdev = pdev;
> spin_lock_init(&cs5535_gpio_chip.lock);
>
> - dev_info(&pdev->dev, "region 0x%x - 0x%x reserved\n",
> - res->start, res->end);
> + dev_info(&pdev->dev, "reserved resource region %pR\n", res);
>
> /* mask out reserved pins */
> mask &= 0x1F7FFFFF;
>
>
OK. How about similar patch for the other warnings:
drivers/misc/cs5535-mfgpt.c:320: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'resource_size_t'
drivers/misc/cs5535-mfgpt.c:320: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'resource_size_t'
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-12-13 20:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 5:36 linux-next: Tree for December 13 Stephen Rothwell
2010-12-13 19:20 ` [PATCH -next] thermal: depends on NET Randy Dunlap
2010-12-20 16:47 ` Randy Dunlap
2011-01-04 17:10 ` Randy Dunlap
2011-01-10 17:00 ` Randy Dunlap
2011-01-12 5:18 ` Len Brown
2011-01-12 17:48 ` on builds/randconfigs (was: [PATCH -next] thermal: depends on NET) Randy Dunlap
2011-01-12 18:35 ` Len Brown
2011-01-12 18:38 ` on builds/randconfigs Randy Dunlap
2011-01-12 21:52 ` Len Brown
2011-01-12 21:18 ` on builds/randconfigs (was: [PATCH -next] thermal: depends on NET) Andrew Morton
2011-01-12 21:24 ` Rafael J. Wysocki
2011-01-12 21:58 ` Len Brown
2011-01-12 22:15 ` Valdis.Kletnieks
2011-01-12 22:54 ` on builds/randconfigs Randy Dunlap
2011-01-13 0:44 ` on builds/randconfigs (was: [PATCH -next] thermal: depends on NET) Stephen Rothwell
2011-01-13 3:31 ` Len Brown
2011-01-13 3:45 ` Steven Rostedt
2011-01-13 3:48 ` Stephen Rothwell
2011-01-13 4:08 ` Linus Torvalds
2011-01-13 12:23 ` on builds/randconfigs Michal Marek
2011-01-15 12:24 ` Vegard Nossum
2011-01-15 16:09 ` Michal Marek
2010-12-13 19:44 ` [PATCH -next] cs5535: fix printk format warnings Randy Dunlap
2010-12-13 20:28 ` [PATCH V2 " Joe Perches
2010-12-13 20:42 ` Randy Dunlap [this message]
2010-12-13 20:57 ` [PATCH V3 " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D06852B.8030409@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dilinger@collabora.co.uk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).