From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH V2 -next] cs5535: fix printk format warnings Date: Mon, 13 Dec 2010 12:42:19 -0800 Message-ID: <4D06852B.8030409@oracle.com> References: <20101213163607.0b0a7c3a.sfr@canb.auug.org.au> <20101213114421.3abe0dcb.randy.dunlap@oracle.com> <1292272085.26970.50.camel@Joe-Laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:51164 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755032Ab0LMUng (ORCPT ); Mon, 13 Dec 2010 15:43:36 -0500 In-Reply-To: <1292272085.26970.50.camel@Joe-Laptop> Sender: linux-next-owner@vger.kernel.org List-ID: To: Joe Perches Cc: Stephen Rothwell , akpm , linux-next@vger.kernel.org, LKML , Andres Salomon On 12/13/10 12:28, Joe Perches wrote: > Use vsprintf extension %pR to format resource. > > Original-patch-by: Randy Dunlap > Signed-off-by: Joe Perches > > --- > > drivers/gpio/cs5535-gpio.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/cs5535-gpio.c b/drivers/gpio/cs5535-gpio.c > index b566fd5e..d7da7a1 100644 > --- a/drivers/gpio/cs5535-gpio.c > +++ b/drivers/gpio/cs5535-gpio.c > @@ -266,8 +266,7 @@ static int __devinit cs5535_gpio_probe(struct platform_device *pdev) > cs5535_gpio_chip.pdev = pdev; > spin_lock_init(&cs5535_gpio_chip.lock); > > - dev_info(&pdev->dev, "region 0x%x - 0x%x reserved\n", > - res->start, res->end); > + dev_info(&pdev->dev, "reserved resource region %pR\n", res); > > /* mask out reserved pins */ > mask &= 0x1F7FFFFF; > > OK. How about similar patch for the other warnings: drivers/misc/cs5535-mfgpt.c:320: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'resource_size_t' drivers/misc/cs5535-mfgpt.c:320: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'resource_size_t' -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***