From: Larry Finger <Larry.Finger@lwfinger.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related)
Date: Wed, 15 Dec 2010 22:49:05 -0600 [thread overview]
Message-ID: <4D099A41.5090502@lwfinger.net> (raw)
In-Reply-To: <20101216142958.e4f463ee.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]
On 12/15/2010 09:29 PM, Stephen Rothwell wrote:
> Hi John,
>
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
>
> drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c: In function 'rtl92c_init_sw_vars':
> drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c:76: error: implicit declaration of function 'vmalloc'
> drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c:76: warning: cast to pointer from integer of different size
> drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c: In function 'rtl92c_deinit_sw_vars':
> drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c:91: error: implicit declaration of function 'vfree'
>
> Caused by commit 0c8173385e549f95cd80c3fff5aab87b4f881d8d ("rtl8192ce:
> Add new driver"). Rule 1 from Documentation/SubmitChecklist.
>
> I have reverted that commit for today.
Sorry for the omission. This error arises because my only platforms get the
header included implicitly.
This patch will fix the problem - I will formally submit it through John Linville.
Larry
---
Index: wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c
+++ wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c
@@ -27,6 +27,8 @@
*
*****************************************************************************/
+#include <linux/vmalloc.h>
+
#include "../wifi.h"
#include "../core.h"
#include "../pci.h"
[-- Attachment #2: rtl8192ce_fix_powerpc_build --]
[-- Type: text/plain, Size: 500 bytes --]
Index: wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c
+++ wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/rtl8192c-sw.c
@@ -27,6 +27,8 @@
*
*****************************************************************************/
+#include <linux/vmalloc.h>
+
#include "../wifi.h"
#include "../core.h"
#include "../pci.h"
next prev parent reply other threads:[~2010-12-16 4:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 3:29 linux-next: build failure after merge of the final tree (wireless tree related) Stephen Rothwell
2010-12-16 4:49 ` Larry Finger [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-22 5:58 Stephen Rothwell
2011-12-22 8:38 ` Kalle Valo
2011-12-22 16:57 ` Michal Marek
2011-12-23 20:50 ` Michal Marek
2011-12-24 1:29 ` Kalle Valo
2011-12-24 1:26 ` Kalle Valo
2011-08-10 2:21 Stephen Rothwell
2011-08-10 6:11 ` Kalle Valo
2011-05-12 4:10 Stephen Rothwell
2011-05-12 4:37 ` Javier Cardona
2011-05-12 4:56 ` Stephen Rothwell
2011-05-12 17:22 ` Javier Cardona
2011-05-12 23:01 ` Stephen Rothwell
2011-02-25 6:16 Stephen Rothwell
2011-02-25 20:33 ` wwguy
2011-02-24 6:24 Stephen Rothwell
2011-02-22 7:15 Stephen Rothwell
2011-02-22 15:45 ` Larry Finger
2011-01-05 4:10 Stephen Rothwell
2010-12-07 3:12 Stephen Rothwell
2010-11-17 2:48 Stephen Rothwell
2010-11-17 16:03 ` Randy Dunlap
2010-11-18 2:27 ` Stephen Rothwell
2010-11-18 21:09 ` Gustavo F. Padovan
2010-10-12 5:35 Stephen Rothwell
2010-03-24 4:59 Stephen Rothwell
2010-03-24 8:13 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D099A41.5090502@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).