From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
George <george0505@realtek.com>,
linux-next@vger.kernel.org
Subject: Re: [PATCH v2] rtlwifi: usb parts should depend on CONFIG_USB
Date: Tue, 01 Mar 2011 13:54:58 -0600 [thread overview]
Message-ID: <4D6D4F12.4000403@lwfinger.net> (raw)
In-Reply-To: <1299005582-7197-1-git-send-email-linville@tuxdriver.com>
On 03/01/2011 12:53 PM, John W. Linville wrote:
> ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_control_msg" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_submit_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_get_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_kill_anchored_urbs" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_put_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_free_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_anchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_alloc_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make: *** [sub-make] Error 2
>
> The USB-part of rtlwifi should depend on CONFIG_USB.
>
> Reported-by: Geert Uytterhoeven<geert@linux-m68k.org>
> Signed-off-by: John W. Linville<linville@tuxdriver.com>
> ---
> drivers/net/wireless/rtlwifi/Makefile | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
John,
If you change the commit message to indicate that you also fixed the case where
CONFIG_PCI is m, then ACK.
Larry
> diff --git a/drivers/net/wireless/rtlwifi/Makefile b/drivers/net/wireless/rtlwifi/Makefile
> index 9192fd5..ec9393f 100644
> --- a/drivers/net/wireless/rtlwifi/Makefile
> +++ b/drivers/net/wireless/rtlwifi/Makefile
> @@ -7,15 +7,18 @@ rtlwifi-objs := \
> efuse.o \
> ps.o \
> rc.o \
> - regd.o \
> - usb.o
> + regd.o
>
> rtl8192c_common-objs += \
>
> -ifeq ($(CONFIG_PCI),y)
> +ifneq ($(CONFIG_PCI),)
> rtlwifi-objs += pci.o
> endif
>
> +ifneq ($(CONFIG_USB),)
> +rtlwifi-objs += usb.o
> +endif
> +
> obj-$(CONFIG_RTL8192C_COMMON) += rtl8192c/
> obj-$(CONFIG_RTL8192CE) += rtl8192ce/
> obj-$(CONFIG_RTL8192CU) += rtl8192cu/
next prev parent reply other threads:[~2011-03-01 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 12:56 [-next] ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! Geert Uytterhoeven
2011-02-28 19:48 ` [PATCH] rtlwifi: usb parts should depend on CONFIG_USB John W. Linville
[not found] ` <1298922500-21632-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2011-02-28 20:08 ` Johannes Berg
[not found] ` <1298923731.10109.0.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2011-02-28 20:13 ` John W. Linville
[not found] ` <20110228201357.GF2515-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2011-02-28 21:16 ` Larry Finger
2011-02-28 21:21 ` Johannes Berg
[not found] ` <1298928111.12230.0.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2011-02-28 21:27 ` Larry Finger
2011-03-01 18:53 ` [PATCH v2] " John W. Linville
2011-03-01 19:54 ` Larry Finger [this message]
2011-02-28 21:01 ` [PATCH] " Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6D4F12.4000403@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=geert@linux-m68k.org \
--cc=george0505@realtek.com \
--cc=johannes@sipsolutions.net \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).