From: Hans de Goede <hdegoede@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jean Delvare <khali@linux-fr.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (jdelvare-hwmon tree related)
Date: Tue, 15 Mar 2011 09:40:41 +0100 [thread overview]
Message-ID: <4D7F2609.3080508@redhat.com> (raw)
In-Reply-To: <20110315192428.ce74a177.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
Hi,
On 03/15/2011 09:24 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/hwmon/sch5627.c: In function 'sch5627_read_virtual_reg':
> drivers/hwmon/sch5627.c:179: error: implicit declaration of function 'msleep'
>
> Caused by commit 19803daeb145 ("hwmon: New driver for SMSC SCH5627").
> See Rule 1 in Documentation/SubmitChecklist.
>
> I have reverted that commit for today.
The attached patch should fix this, Jean can you please add this to your
tree? Note feel free to merge it into the initial patch adding the sch5627 driver
if you prefer.
Thanks & Regards,
Hans
[-- Attachment #2: 0001-hwmon-sch5627-include-linux-delay.h-for-msleep-proto.patch --]
[-- Type: text/plain, Size: 799 bytes --]
>From a5ffc5ddcdb230fcb10fe6c80ebe043c25763416 Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@redhat.com>
Date: Tue, 15 Mar 2011 09:37:47 +0100
Subject: [PATCH] hwmon/sch5627: include linux/delay.h for msleep prototype
This should fix sch5627 breaking the building of linux-next
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/hwmon/sch5627.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hwmon/sch5627.c b/drivers/hwmon/sch5627.c
index 0001331..9a51dcc 100644
--- a/drivers/hwmon/sch5627.c
+++ b/drivers/hwmon/sch5627.c
@@ -30,6 +30,7 @@
#include <linux/mutex.h>
#include <linux/io.h>
#include <linux/acpi.h>
+#include <linux/delay.h>
#define DRVNAME "sch5627"
#define DEVNAME DRVNAME /* We only support one model */
--
1.7.3.2
next prev parent reply other threads:[~2011-03-15 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 8:24 linux-next: build failure after merge of the final tree (jdelvare-hwmon tree related) Stephen Rothwell
2011-03-15 8:40 ` Hans de Goede [this message]
2011-03-15 9:32 ` Jean Delvare
2011-03-15 10:22 ` Stephen Rothwell
2011-03-16 11:30 ` Jean Delvare
2011-03-17 12:18 ` Geert Uytterhoeven
2011-03-17 15:36 ` Jean Delvare
2011-03-16 16:16 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2010-10-06 4:28 Stephen Rothwell
2010-10-06 7:05 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7F2609.3080508@redhat.com \
--to=hdegoede@redhat.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox