From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI Date: Tue, 12 Apr 2011 08:48:12 -0700 Message-ID: <4DA4743C.7070408@oracle.com> References: <20110408083215.6b3b0bfe.randy.dunlap@oracle.com> <20110412114722.0f2e67d6@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:53195 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757640Ab1DLPsz (ORCPT ); Tue, 12 Apr 2011 11:48:55 -0400 In-Reply-To: <20110412114722.0f2e67d6@endymion.delvare> Sender: linux-next-owner@vger.kernel.org List-ID: To: Jean Delvare Cc: Geert Uytterhoeven , Stephen Rothwell , Ben Dooks , Baruch Siach , linux-i2c@vger.kernel.org, linux-next@vger.kernel.org, LKML On 04/12/11 02:47, Jean Delvare wrote: > Geert, Randy, > > On Sat, 9 Apr 2011 13:34:49 +0200, Geert Uytterhoeven wrote: >> On Fri, Apr 8, 2011 at 17:32, Randy Dunlap wrote: >>> From: Randy Dunlap >>> >>> i2c-designware-pcidrv is a PCI driver and should depend on PCI. >>> Fixes these build errors: >>> >>> drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region' >>> drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region' >>> >>> Signed-off-by: Randy Dunlap >>> Cc: Baruch Siach >>> --- >>> drivers/i2c/busses/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> Does anybody merge i2c patches??? >> >> Yes please, it's been there since Mar 17, reported several times, and probably >> masking other build failures. > > This bug only exists in linux-next, as the code in question wasn't > merged in Linus's tree yet. It is drawn into linux-next from Ben > Dooks's next-i2c branch: > http://git.fluff.org/gitweb?p=bjdooks/linux.git;a=shortlog;h=refs/heads/next-i2c > > This is where it has to be fixed, so only Ben can do it. Ben, please? > > Meanwhile, it should be possible to apply a hot fix to linux-next > directly, Stephen does it pretty often. Stephen, could you please apply > this fix temporarily until Ben wakes up and applies it to his tree? Thanks, Jean. >>> --- linux-next-20110316.orig/drivers/i2c/busses/Kconfig >>> +++ linux-next-20110316/drivers/i2c/busses/Kconfig >>> @@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM >>> >>> config I2C_DESIGNWARE_PCI >>> tristate "Synopsys DesignWare PCI" >>> + depends on PCI >>> help >>> If you say yes to this option, support will be included for the >>> Synopsys DesignWare I2C adapter. Only master mode is supported. > -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***