From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-media@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
gregkh@suse.de, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"Igor M. Liplianin" <liplianin@netup.ru>
Subject: Re: Fw: [PATCH -next RESEND/still needed] staging: altera-jtag needs delay.h
Date: Thu, 19 May 2011 16:22:06 -0300 [thread overview]
Message-ID: <4DD56DDE.6060003@infradead.org> (raw)
In-Reply-To: <20110328082305.c6fa41d9.randy.dunlap@oracle.com>
Em 28-03-2011 12:23, Randy Dunlap escreveu:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> altera-jtag.c needs to include <linux/delay.h> to fix a build error:
>
> drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: Igor M. Liplianin <liplianin@netup.ru>
> ---
> drivers/staging/altera-stapl/altera-jtag.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Somehow I was supposed to know to send this to Mauro instead of to Greg,
> but I don't see anything in drivers/staging/altera-stapl/ that says that.
Ah, yes, we need to add a readme file there stating about that.
Greg, you may add it on your tree, or if you prefer, I can just add here for
my next upstream pull.
Thanks,
Mauro.
>
>
> --- linux-next-20110304.orig/drivers/staging/altera-stapl/altera-jtag.c
> +++ linux-next-20110304/drivers/staging/altera-stapl/altera-jtag.c
> @@ -23,6 +23,7 @@
> * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> */
>
> +#include <linux/delay.h>
> #include <linux/firmware.h>
> #include <linux/slab.h>
> #include <staging/altera.h>
> --
next prev parent reply other threads:[~2011-05-19 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 15:23 Fw: [PATCH -next RESEND/still needed] staging: altera-jtag needs delay.h Randy Dunlap
2011-05-19 19:22 ` Mauro Carvalho Chehab [this message]
2011-05-19 20:39 ` Greg KH
2011-05-19 20:41 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD56DDE.6060003@infradead.org \
--to=mchehab@infradead.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=liplianin@netup.ru \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).