From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
x86@kernel.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH -next] x86: apic_flat_64.c needs module.h
Date: Mon, 23 May 2011 21:51:39 +0400 [thread overview]
Message-ID: <4DDA9EAB.40304@gmail.com> (raw)
In-Reply-To: <20110523104300.dd532a99.randy.dunlap@oracle.com>
On 05/23/2011 09:43 PM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> apic_flat_64.c needs to include module.h to fix these warnings:
>
> arch/x86/kernel/apic/apic_flat_64.c:31: warning: data definition has no type or storage class
> arch/x86/kernel/apic/apic_flat_64.c:31: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/x86/kernel/apic/apic_flat_64.c:31: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> arch/x86/kernel/apic/apic_flat_64.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20110523.orig/arch/x86/kernel/apic/apic_flat_64.c
> +++ linux-next-20110523/arch/x86/kernel/apic/apic_flat_64.c
> @@ -16,6 +16,7 @@
> #include <linux/ctype.h>
> #include <linux/init.h>
> #include <linux/hardirq.h>
> +#include <linux/module.h>
> #include <asm/smp.h>
> #include <asm/apic.h>
> #include <asm/ipi.h>
Thanks Randy! For some reason I didn't hit this problem while
were compiling the kernel and testing it (I usually do not use
modules though).
I've CC'ed Ingo and Suresh.
--
Cyrill
next prev parent reply other threads:[~2011-05-23 17:51 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 5:45 linux-next: Tree for May 23 Stephen Rothwell
2011-05-23 16:42 ` linux-next: Tree for May 23 (infiniband + netlink) Randy Dunlap
[not found] ` <20110523094205.4a5651d2.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2011-05-23 18:05 ` Roland Dreier
2011-05-23 17:43 ` [PATCH -next] x86: apic_flat_64.c needs module.h Randy Dunlap
2011-05-23 17:51 ` Cyrill Gorcunov [this message]
2011-05-23 18:09 ` Cyrill Gorcunov
2011-05-23 18:12 ` Randy Dunlap
2011-05-23 18:35 ` Cyrill Gorcunov
2011-05-23 19:10 ` Ingo Molnar
2011-05-23 19:26 ` Ingo Molnar
2011-05-23 17:49 ` linux-next: Tree for May 23 (hwmon/coretemp.c) Randy Dunlap
2011-05-23 18:03 ` Guenter Roeck
2011-05-23 18:35 ` [PATCH -next] target: fix tfc_io.c printk format warning Randy Dunlap
2011-05-23 20:47 ` Nicholas A. Bellinger
2011-06-16 18:35 ` Randy Dunlap
2011-05-23 18:37 ` [PATCH -next] mtd: fix physmap.h warnings Randy Dunlap
2011-05-24 5:53 ` Artem Bityutskiy
2011-05-24 5:58 ` Artem Bityutskiy
2011-05-24 7:40 ` Russell King
2011-05-24 7:40 ` Artem Bityutskiy
2011-05-24 7:42 ` Artem Bityutskiy
2011-06-01 7:45 ` Artem Bityutskiy
2011-06-01 8:05 ` Russell King
2011-05-24 7:41 ` Artem Bityutskiy
2011-05-23 20:48 ` linux-next: Tree for May 23 (sound/soc/codecs) Randy Dunlap
2011-05-23 22:47 ` Mark Brown
2011-05-23 22:53 ` Randy Dunlap
2011-05-24 0:08 ` Mark Brown
2011-05-24 1:21 ` Randy Dunlap
2011-05-24 1:50 ` Mark Brown
2011-05-24 4:58 ` [PATCH/RFC] gpio: add GPIOF_ values regardless on kconfig settings Randy Dunlap
2011-05-24 5:23 ` Dmitry Artamonow
2011-05-24 19:44 ` Randy Dunlap
2011-05-24 7:52 ` Mark Brown
2011-05-27 7:45 ` [alsa-devel] " Grant Likely
2011-05-27 17:46 ` [PATCH] " Randy Dunlap
2011-05-27 20:12 ` Grant Likely
2011-06-03 17:04 ` Grant Likely
2011-06-03 17:18 ` Mark Brown
2011-06-03 17:42 ` Grant Likely
2011-06-06 3:45 ` Randy Dunlap
2011-06-14 16:12 ` Randy Dunlap
2011-06-14 16:13 ` Grant Likely
2011-06-15 0:03 ` Randy Dunlap
2011-06-15 0:05 ` [PATCH 1/2] " Randy Dunlap
2011-06-16 14:37 ` Grant Likely
2011-06-15 0:06 ` [PATCH 2/2] gpio: include linux/gpio.h where needed Randy Dunlap
2011-06-15 0:34 ` Stephen Rothwell
2011-06-15 17:59 ` Randy Dunlap
2011-06-15 19:21 ` Grant Likely
2011-06-16 14:37 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDA9EAB.40304@gmail.com \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=suresh.b.siddha@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).