From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [Kgdb-bugreport] [PATCH] kgdbts: only use new asm-generic/ptrace.h api when needed Date: Mon, 30 May 2011 13:51:06 +0400 Message-ID: <4DE3688A.4040600@mvista.com> References: <20110527151135.cd6f758a.sfr@canb.auug.org.au> <1306591465-9622-1-git-send-email-vapier@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:38621 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753317Ab1E3Jv7 (ORCPT ); Mon, 30 May 2011 05:51:59 -0400 In-Reply-To: <1306591465-9622-1-git-send-email-vapier@gentoo.org> Sender: linux-next-owner@vger.kernel.org List-ID: To: Mike Frysinger Cc: kgdb-bugreport@lists.sourceforge.net, Jason Wessel , Andrew Morton , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Hello. On 28-05-2011 18:04, Mike Frysinger wrote: > The new instruction_pointer_set helper is defined for people who have > converted to asm-generic/ptrace.h, so don't use it generally unless > the arch needs it (in which case it has been converted). This should > fix building of kgdb tests for arches not yet converted. > Signed-off-by: Mike Frysinger > --- > drivers/misc/kgdbts.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c > index b0c5631..8cebec5 100644 > --- a/drivers/misc/kgdbts.c > +++ b/drivers/misc/kgdbts.c > @@ -304,7 +304,10 @@ static int check_and_rewind_pc(char *put_str, ch= ar *arg) > return 1; > } > /* Readjust the instruction pointer if needed */ > - instruction_pointer_set(&kgdbts_regs, ip + offset); > + ip +=3D offset; Since '=EDp' is local, incrementing it is pointless here unless you= have=20 GDB_ADJUSTS_BREAK_OFFSET defined. Why not keep instruction_pointer_set(= ) call=20 as is? > +#ifdef GDB_ADJUSTS_BREAK_OFFSET > + instruction_pointer_set(&kgdbts_regs, ip); > +#endif > return 0; > } > WBR, Sergei