From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Roskin Subject: Re: [PATCH -next] bcma: main.c needs to include Date: Mon, 27 Jun 2011 13:22:12 -0400 Message-ID: <4E08BC44.3020105@gnu.org> References: <4E08B4AA.409@broadcom.com> (sfid-20110627_185027_507290_BCE834F5) <1309193844.3911.27.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from c60.cesmail.net ([216.154.195.49]:61589 "EHLO c60.cesmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474Ab1F0RWO (ORCPT ); Mon, 27 Jun 2011 13:22:14 -0400 In-Reply-To: <1309193844.3911.27.camel@jlt3.sipsolutions.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: Johannes Berg Cc: Arend van Spriel , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Alexey Dobriyan , Geert Uytterhoeven , "linux-wireless@vger.kernel.org" , "linux-next@vger.kernel.org" , Linux Kernel Development On 06/27/2011 12:57 PM, Johannes Berg wrote: > Yeah, good rule. Consider if you have a.h, b.h and z.c, z.c needs b.h > but not a.h, and now b.h includes a.h ("for convenience") -- changing > a.h would needlessly recompile z.c. Now, changing slab.h will probably > recompile everything anyway, but still... In my configuration after touching slab.h and recompilation: $ find -name '*.o' -newer ../linux3/include/linux/slab.h |wc -l 1508 $ find -name '*.o' |wc -l 1928 78% object files were recompiled, 22% were no recompiled. Careful use of includes does save time. -- Regards, Pavel Roskin