From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: linux-next: Tree for July 4 (misc/pti) Date: Fri, 08 Jul 2011 14:31:23 -0700 Message-ID: <4E17772B.3060906@oracle.com> References: <20110704170952.1024e89b.sfr@canb.auug.org.au> <20110704134541.9adfd4f1.randy.dunlap@oracle.com> <20110707081441.a4a64e59.randy.dunlap@oracle.com> <4E15DF07.4010507@linux.intel.com> <20110707093202.a831fce8.randy.dunlap@oracle.com> <4E17757C.5030909@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from acsinet15.oracle.com ([141.146.126.227]:17305 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753784Ab1GHVbm (ORCPT ); Fri, 8 Jul 2011 17:31:42 -0400 In-Reply-To: <4E17757C.5030909@linux.intel.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: J Freyensee Cc: Geert Uytterhoeven , lkml , Stephen Rothwell , linux-next@vger.kernel.org On 07/08/11 14:24, J Freyensee wrote: > On 07/08/2011 01:07 PM, Geert Uytterhoeven wrote: >> On Thu, Jul 7, 2011 at 18:32, Randy Dunlap >> wrote: >>> On Thu, 07 Jul 2011 09:29:59 -0700 J Freyensee wrote: >>>> On 07/07/2011 08:14 AM, Randy Dunlap wrote: >>>>> On Mon, 4 Jul 2011 13:45:41 -0700 Randy Dunlap wrote: >>>>>> On Mon, 4 Jul 2011 17:09:52 +1000 Stephen Rothwell wrote: >>>>>>> Changes since 20110701: >>>>>> when CONFIG_PCI is not enabled: >>>>>> >>>>>> drivers/misc/pti.c:410: error: implicit declaration of function >>>>>> 'pci_release_region' >>>>>> drivers/misc/pti.c:859: error: implicit declaration of function >>>>>> 'pci_request_region' >>>>>> >>>>>> Stubs for these 2 functions could be added to include/linux/pci.h, >>>>>> but it would >>>>>> make more sense to me just to make the driver depend on PCI since >>>>>> it seems to rely >>>>>> on so many PCI functions. or are the PCI pieces optional? >>>>> ping. still a problem in linux-next 20110706. >>>> Thanks for the ping. >>>> >>>> Is there something you need me to do or look at? >>>> >>>> For Intel-Atom architectures, the MIPI PTI module does sit on the PCI >>>> bus. It's very much dependent upon the PCI bus for working >>>> functionality and it's not optional. So yes, it makes sense for the >>>> driver to depend on PCI to be there and if PCI is not enabled on the >>>> system, don't build the pti driver. >>>> >>>> Maybe it's a Kconfig dependency? >>> Yes, please send/merge a patch that adds >>> depends on PCI >>> to "config INTEL_MID_PCI". >> http://kisskb.ellerman.id.au/kisskb/buildresult/4292241/: > I can't access that http site (with or without the ':'). Works for me (without the trailing colon). >> drivers/misc/pti.c:249: error: implicit declaration of function 'kmalloc' >> drivers/misc/pti.c:258: error: implicit declaration of function 'kfree' >> drivers/misc/pti.c:657: error: implicit declaration of function >> 'copy_from_user' >> drivers/misc/pti.c:848: error: implicit declaration of function 'kzalloc' >> >> Probably missing > >> >> #include >> #include > > I can send a patch to add these two includes. It didn't have previous > troubles compiling, so maybe one of the other includes used to be > including these? That URL (above) says: Compiler: m68k (m68k-linux-gcc (GCC) 4.4.0) and different $ARCH-es do different #inclusions. Anyway, the interfaces are used so the source file should #include the header files. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***