From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 1/1] asm-generic: delay.h fix udelay and ndelay for 8 bit args Date: Fri, 22 Jul 2011 12:11:06 -0700 Message-ID: <4E29CB4A.40508@zytor.com> References: <1310986975.21015.13.camel@needafix> <1310997937-26771-1-git-send-email-jonas@southpole.se> <1311361492.2660.13.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:37957 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754861Ab1GVTL5 (ORCPT ); Fri, 22 Jul 2011 15:11:57 -0400 In-Reply-To: <1311361492.2660.13.camel@localhost> Sender: linux-next-owner@vger.kernel.org List-ID: To: Jonas Bonn Cc: sfr@canb.auug.org.au, Andrew Morton , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner On 07/22/2011 12:04 PM, Jonas Bonn wrote: > > On Mon, 2011-07-18 at 16:05 +0200, Jonas Bonn wrote: >> From: Andrew Morton >> >> With a non-constant 8-bit argument, a call to udelay() generates a warning: >> > > >> --- >> >> Here's a patch that should resolve the merge conflict. This applies >> Andrew's changes on top of the new asm-generic/delay.h instead of the x86 >> arch-specific one. I've tested this for OpenRISC and the changed macros >> don't cause any problems there. >> >> Let me know if this is OK and I'll throw it into the OpenRISC tree together >> with the other delay.h modifications. >> > > I haven't gotten any feedback on this... since the change looks > appropriate to merge with the other changes to asm-generic/delay.h, I'll > apply this patch there and carry the patch together with the other > asm-generic/delay.h changes in the 'openrisc' tree. Andrew can drop the > patch from his series to avoid the merge conflict. > > I hope that works for everybody... > You may want to Cc: Arnd on this, since he's the asm-generic maintainer. Otherwise, since this is zero work on our part, it obviously works for me. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.